From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: getting rid of subsys_initcall usage? (was: Re: [PATCH RESEND] i2c: designware: use module_platform_driver) Date: Fri, 30 Aug 2013 01:27:13 -0700 Message-ID: <20130830082712.GT7656@atomide.com> References: <1376987548-12366-1-git-send-email-zhangfei.gao@linaro.org> <20130828095706.GH4086@katana> <20130830054858.GR7656@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: zhangfei gao Cc: Linus Walleij , Wolfram Sang , Zhangfei Gao , Baruch Siach , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Haojian Zhuang List-Id: linux-i2c@vger.kernel.org * zhangfei gao [130829 23:36]: > What about concerns from Wolfram: > " Other people might be > depending on subsys_initcall to get I2C active before they want to > activate, say, PMICs. So, I fear regressions, since deferred probing > might not be available in the needed places to avoid these regressions." There should not be any reason to get a PMIC activated early on. The system should be booting already at that point, and the PMIC related init can be done later on. > Is it too late using module_init for PMIC? You can probably do it as a fix early on during the -rc cycle too. Of course it needs to be verified to work first :) > Besides, the deferred probing still there if depend on late registered > pin control driver. At least for omaps we have things working just fine with pinctrl-single and a PMIC on I2C controller. Regards, Tony