Re: [PATCH] i2c-designware: define i2c_dw_pci_runtime_idle only with runtime pm

Mika Westerberg
2013-09-27T08:22:59Z

On Fri, Sep 27, 2013 at 04:43:13AM +0200, Wolfram Sang wrote:
> On Fri, Sep 27, 2013 at 12:24:03AM +0200, Vincent Stehlé wrote:
> > Make sure i2c_dw_pci_runtime_idle() is defined only when actually used, when
> > CONFIG_PM_RUNTIME is defined.
> >
> > This fixes the following compilation warning:
> >
> > drivers/i2c/busses/i2c-designware-pcidrv.c:188:12: warning: ‘i2c_dw_pci_runtime_idle’ defined but not used [-Wunused-function]
> >
> > Signed-off-by: Vincent Stehlé <vincent.stehle-QFKgK+z4sOrR7s880joybQ@public.gmane.org>
> > Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
>
> I wonder if this fix is complete? Mika?
>
> > ---
> > drivers/i2c/busses/i2c-designware-pcidrv.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
> > index f6ed06c..2b5d3a6 100644
> > --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> > +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> > @@ -185,6 +185,7 @@ static int i2c_dw_pci_resume(struct device *dev)
> > return 0;
> > }
> >
> > +#ifdef CONFIG_PM_RUNTIME
> > static int i2c_dw_pci_runtime_idle(struct device *dev)
> > {
> > int err = pm_schedule_suspend(dev, 500);
> > @@ -194,6 +195,7 @@ static int i2c_dw_pci_runtime_idle(struct device *dev)
> > return 0;
> > return -EBUSY;
> > }
> > +#endif
> >
> > static const struct dev_pm_ops i2c_dw_pm_ops = {
>
> Shouldn't this be using UNIVERSAL_DEV_PM_OPS with the suspend and resume
> function #ifdeffed by CONFIG_PM_SLEEP?

Yes, I think that would be better.

>
> > .resume = i2c_dw_pci_resume,
> > --
> > 1.8.4.rc3
> >