From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH v2 3/3] i2c: xilinx: Use devm_* functions Date: Fri, 4 Oct 2013 07:33:23 +0200 Message-ID: <20131004053323.GB3194@katana> References: <83ec9558211389896f21d9682e9824cd7979466c.1380550490.git.michal.simek@xilinx.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jho1yZJdad60DJr+" Return-path: Content-Disposition: inline In-Reply-To: <83ec9558211389896f21d9682e9824cd7979466c.1380550490.git.michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Michal Simek Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org, Kedareswara rao Appana , Kedareswara rao Appana , Jean Delvare , Peter Korsgaard , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org --jho1yZJdad60DJr+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + i2c->base = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(i2c->base)) { > + dev_err(&pdev->dev, "Could not allocate iomem\n"); devm_ioremap_resource already prints error messages. > + ret = devm_request_irq(&pdev->dev, irq, xiic_isr, 0, pdev->name, i2c); This is too early. Can you find out why? > + pdata = (struct xiic_i2c_platform_data *)dev_get_platdata(&pdev->dev); Casting a void pointer? --jho1yZJdad60DJr+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJSTlMiAAoJEBQN5MwUoCm2gJcP/RkSsvPNjrK3RgKAAWfHjHmU ZSn12a/jHOfzKEr9ZHiwEsYPk/jFNVljnwDTtzXExyU8ckuG45dTRAwnZUkcX03/ w3LJsRJtrwXkT8AGLCshaclRxjy0Z45hUD2jJzJqThSH/nRdkUZNu11rbrXaPvSp 52SZOSg+nqLAXaV/l8zM2Bdi/EHgop6XGY7I0AYy5MSw52zh3yxMgxkD6a91HB5T 8DH1EF3xJIgqJ79bdeee9AwqQksgSxev83aBhV3dP5H3W6qTN8bUClZPLjzYIF1H pAYnXylzPpVTgrJbD7X2+LoYx7j1iTwT4AfoS74SMwT+Oa7+fK9dG89j68EhBd2Z zqAMkxURGMd44uX5hTvde+bUHVD6UckHNXgx9s4G6K7b2I6eefv0Po+/8Onnk/VF m6MVWRH16GjQlrpdRVLMAyEmItbY5prZL+yRZfcNdHBdL2I+9Nhv5nhp9TAU0Co4 oajCUdvWzb1XN5KqfKmQprfcp9EpNF7+IthW9Yor6p119G1L9c8ydAVmR2ZGl7FP Oz0jk7WdtH9IEEnbMEThWSwC43COMJRoAhoeFkfhIEHNTxc8vjjvgr1q9yMtIF6s Y4QKFirG+Vzudn8YT6a9eVRQX9djzcuXHT7J00D0WzQXWHggCpe/Pm80/qziD1aZ jpSgEir0YanuehMiE6FN =hh5Q -----END PGP SIGNATURE----- --jho1yZJdad60DJr+--