From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Kuninori Morimoto
<kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Kuninori Morimoto
<kuninori.morimoto.gx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Simon <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
Subject: Re: [PATCH resend] i2c: rcar: fixup rcar type naming
Date: Wed, 30 Oct 2013 17:11:26 +0100 [thread overview]
Message-ID: <20131030161126.GG3663@katana> (raw)
In-Reply-To: <87ppqzaw37.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]
On Mon, Oct 21, 2013 at 01:04:32AM -0700, Kuninori Morimoto wrote:
> b720423a2627f045133bec39a31fe2bc0dab86f3
> (i2c: rcar: add rcar-H2 support)
> added R-Car H2 support on i2c-rcar.
>
> The R-Car I2C type is based on SoC generation
> (Gen1 = E1/M1/H1, Gen2 = E2/M2/H2),
> but added naming was H1/H2 instead of Gen1/Gen2.
> Gen1/Gen2 is better naming on this driver.
I'd prefer to not change the code, but rather add comments after the
enum types saying this enum applies to the whole generation... Drivers
often start with specific naming. And while things turn out to be more
generic later, IMO it is not worth to keep the naming in sync with
ip-core namings.
> static struct platform_device_id rcar_i2c_id_table[] = {
> - { "i2c-rcar", I2C_RCAR_H1 },
> - { "i2c-rcar_h1", I2C_RCAR_H1 },
> - { "i2c-rcar_h2", I2C_RCAR_H2 },
> + { "i2c-rcar", I2C_RCAR_GEN1 },
> + { "i2c-rcar_gen1", I2C_RCAR_GEN1 },
> + { "i2c-rcar_gen2", I2C_RCAR_GEN2 },
> {},
Renaming the platform_device_ids will cause regressions, too!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-10-30 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 6:36 [PATCH] i2c: rcar: fixup rcar type naming Kuninori Morimoto
[not found] ` <87ob75zgn2.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2013-10-21 8:04 ` [PATCH resend] " Kuninori Morimoto
[not found] ` <87ppqzaw37.wl%kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
2013-10-29 5:48 ` Simon Horman
2013-10-30 16:11 ` Wolfram Sang [this message]
2013-10-31 1:11 ` Kuninori Morimoto
2013-10-31 12:02 ` [PATCH] " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030161126.GG3663@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
--cc=kuninori.morimoto.gx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).