From: Andreas Werner <wernerandy@gmx.de>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: khali@linux-fr.org, jacmet@sunsite.dk, hskinnemoen@gmail.com,
dianders@chromium.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] I2C: busses: i2c-eg20t Do not print error message in syslog if no ACK received
Date: Sun, 17 Nov 2013 17:53:29 +0100 [thread overview]
Message-ID: <20131117165329.GA1562@thinkpad.fritz.box> (raw)
In-Reply-To: <20131117121809.GC3093@katana>
On Sun, Nov 17, 2013 at 01:18:09PM +0100, Wolfram Sang wrote:
>
> > Is there another reason why pch_i2c_getack returned EPROTO?
> > May be ENXIO was introduced later?
>
> Imperfect review :)
>
> > I think we can just replace the -EIO with -ENXIO or do you want to pick up the return
> > vale of pch_i2c_getack and return that ?
>
> The latter. As a rule of thumb, it is usually more sustainable to pass
> through error codes. Overloading them should only be done when really
> necessary IMO.
>
Ok, if that will be ok in pch_i2c_wait_for_check_xfer i will resend
the patch.
ret = pch_i2c_getack(adap);
if (ret)
pch_dbg(adap, "Receive NACK for slave address setting\n");
return (int)ret;
Regards
Andy
next prev parent reply other threads:[~2013-11-17 16:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-17 8:58 [PATCH v2] I2C: busses: i2c-eg20t Do not print error message in syslog if no ACK received Andreas Werner
[not found] ` <1384678731-10399-1-git-send-email-wernerandy-Mmb7MZpHnFY@public.gmane.org>
2013-11-17 11:08 ` Wolfram Sang
2013-11-17 12:39 ` Andreas Werner
2013-11-17 12:18 ` Wolfram Sang
2013-11-17 16:53 ` Andreas Werner [this message]
[not found] ` <20131117165329.GA1562-Zv899e0YUSYXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2013-11-17 17:08 ` Wolfram Sang
2013-11-17 17:16 ` Andreas Werner
2013-11-17 17:31 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131117165329.GA1562@thinkpad.fritz.box \
--to=wernerandy@gmx.de \
--cc=dianders@chromium.org \
--cc=hskinnemoen@gmail.com \
--cc=jacmet@sunsite.dk \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).