* [PATCH -next] i2c: bcm-kona: fix error return code in bcm_kona_i2c_probe()
@ 2013-11-18 13:03 Wei Yongjun
[not found] ` <CAPgLHd8vdQL5Uyypjj_L9qg=abQEXoGc6ZBKwrF-5D9x2YNm-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2013-11-18 13:03 UTC (permalink / raw)
To: wsa-z923LK4zBo2bacvFa/9K2g, grant.likely-QSEj5FYQhm4dnm+yROfE0A,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ,
tim.kryger-QSEj5FYQhm4dnm+yROfE0A,
matt.porter-QSEj5FYQhm4dnm+yROfE0A,
markus.mayer-QSEj5FYQhm4dnm+yROfE0A
Cc: yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY,
linux-i2c-u79uwXL29TY76Z2rM5mHXA
From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
Fix to return a negative error code from the bus speed parse
error handling case instead of 0.
Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
---
drivers/i2c/busses/i2c-bcm-kona.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-bcm-kona.c b/drivers/i2c/busses/i2c-bcm-kona.c
index 865e5dd..036cf03 100644
--- a/drivers/i2c/busses/i2c-bcm-kona.c
+++ b/drivers/i2c/busses/i2c-bcm-kona.c
@@ -792,7 +792,8 @@ static int bcm_kona_i2c_probe(struct platform_device *pdev)
}
/* Parse bus speed */
- if (bcm_kona_i2c_assign_bus_speed(dev))
+ rc = bcm_kona_i2c_assign_bus_speed(dev);
+ if (rc)
goto probe_disable_clk;
/* Enable internal clocks */
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] i2c: bcm-kona: fix error return code in bcm_kona_i2c_probe()
[not found] ` <CAPgLHd8vdQL5Uyypjj_L9qg=abQEXoGc6ZBKwrF-5D9x2YNm-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2013-11-18 17:05 ` Tim Kryger
2013-11-18 19:26 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Tim Kryger @ 2013-11-18 17:05 UTC (permalink / raw)
To: Wei Yongjun
Cc: Wolfram Sang, Grant Likely, Rob Herring, Matt Porter,
Markus Mayer, yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY,
Linux I2C List
On Mon, Nov 18, 2013 at 5:03 AM, Wei Yongjun <weiyj.lk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
>
> Fix to return a negative error code from the bus speed parse
> error handling case instead of 0.
>
> Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-bcm-kona.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-bcm-kona.c b/drivers/i2c/busses/i2c-bcm-kona.c
> index 865e5dd..036cf03 100644
> --- a/drivers/i2c/busses/i2c-bcm-kona.c
> +++ b/drivers/i2c/busses/i2c-bcm-kona.c
> @@ -792,7 +792,8 @@ static int bcm_kona_i2c_probe(struct platform_device *pdev)
> }
>
> /* Parse bus speed */
> - if (bcm_kona_i2c_assign_bus_speed(dev))
> + rc = bcm_kona_i2c_assign_bus_speed(dev);
> + if (rc)
> goto probe_disable_clk;
>
> /* Enable internal clocks */
>
Looks good. Thanks.
Reviewed-by: Tim Kryger <tim.kryger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] i2c: bcm-kona: fix error return code in bcm_kona_i2c_probe()
[not found] ` <CAPgLHd8vdQL5Uyypjj_L9qg=abQEXoGc6ZBKwrF-5D9x2YNm-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-18 17:05 ` Tim Kryger
@ 2013-11-18 19:26 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2013-11-18 19:26 UTC (permalink / raw)
To: Wei Yongjun
Cc: grant.likely-QSEj5FYQhm4dnm+yROfE0A,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ,
tim.kryger-QSEj5FYQhm4dnm+yROfE0A,
matt.porter-QSEj5FYQhm4dnm+yROfE0A,
markus.mayer-QSEj5FYQhm4dnm+yROfE0A,
yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY,
linux-i2c-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
On Mon, Nov 18, 2013 at 09:03:08PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
>
> Fix to return a negative error code from the bus speed parse
> error handling case instead of 0.
>
> Signed-off-by: Wei Yongjun <yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org>
Applied to for-next, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-18 19:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-18 13:03 [PATCH -next] i2c: bcm-kona: fix error return code in bcm_kona_i2c_probe() Wei Yongjun
[not found] ` <CAPgLHd8vdQL5Uyypjj_L9qg=abQEXoGc6ZBKwrF-5D9x2YNm-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-18 17:05 ` Tim Kryger
2013-11-18 19:26 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).