From: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: designware: remove HAVE_CLK build dependecy
Date: Sun, 5 Jan 2014 07:04:10 +0200 [thread overview]
Message-ID: <20140105050410.GA5316@tarshish> (raw)
In-Reply-To: <20140104224846.GH3150@katana>
Hi Wolfram,
On Sat, Jan 04, 2014 at 11:48:46PM +0100, Wolfram Sang wrote:
> On Mon, Dec 30, 2013 at 10:31:19AM +0200, Baruch Siach wrote:
> > Since 93abe8e4 (clk: add non CONFIG_HAVE_CLK routines) code using clk.h need
> > not depend on HAVE_CLK. Also, remove a redundant clk.h include from core driver
> > file.
> >
> > Signed-off-by: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
>
> Is the patch description correct? The core driver simply does not need
> clk.h and thus the dependency. No redundancy here, or?
The platform code (i2c-designware-platform.c) uses the clk API, but the
Kconfig dependency on HAVE_CLK is not needed anymore. The core code
(i2c-designware-core.c) doesn't use clk. Originally the driver was in a single
file, including the clk handling. This code has been moved to the platform
file, so the core file doesn't need the clk.h include.
Logically, these are two separate issues. But I'm not sure it is worth
splitting into two patches. What do you think?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2014-01-05 5:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-30 8:31 [PATCH] i2c: designware: remove HAVE_CLK build dependecy Baruch Siach
[not found] ` <f3ebead75d45623e4b649c7a8d0112584ffd1788.1388392279.git.baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
2014-01-04 22:48 ` Wolfram Sang
2014-01-05 5:04 ` Baruch Siach [this message]
2014-01-13 12:18 ` Baruch Siach
2014-01-13 12:39 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140105050410.GA5316@tarshish \
--to=baruch-nswtu9s1w3p6gbpvegmw2w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).