From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Cooper Subject: Re: [PATCH v5 4/4] i2c: mv64xxx: Document the newly introduced Armada XP A0 compatible Date: Fri, 10 Jan 2014 16:55:26 -0500 Message-ID: <20140110215526.GB19878@titan.lakedaemon.net> References: <1389193589-18485-1-git-send-email-gregory.clement@free-electrons.com> <1389193589-18485-5-git-send-email-gregory.clement@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1389193589-18485-5-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Gregory CLEMENT Cc: Wolfram Sang , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andrew Lunn , Arnd Bergmann , Thomas Petazzoni , Ezequiel Garcia , Sebastian Hesselbarth , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org Gregory, On Wed, Jan 08, 2014 at 04:06:29PM +0100, Gregory CLEMENT wrote: > The first variants of Armada XP SoCs (A0 stepping) have issues related > to the i2c controller which prevent to use the offload mechanism and > ead to a kernel hang during boot. I'll fixup s/ead/lead/ here. > > The commit introduces a new the compatible string > marvell,mv78230-a0-i2c for the i2c controller. > > Signed-off-by: Gregory CLEMENT > cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > --- > Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt > index 82e8f6f17179..9410ed72ec45 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt > @@ -5,7 +5,7 @@ Required properties : > > - reg : Offset and length of the register set for the device > - compatible : Should be "marvell,mv64xxx-i2c" or "allwinner,sun4i-i2c" > - or "marvell,mv78230-i2c" > + or "marvell,mv78230-i2c" or "marvell,mv78230-a0-i2c" If it's ok with you Gregory, I'll amend this hunk as follows: or "marvell,mv78230-i2c" or "marvell,mv78230-a0-i2c" Only use "marvell,mv78230-a0-i2c" for a very rare, initial version of the SoC which had broken offload support. Linux auto-detects this and sets it appropriately. thx, Jason. > - interrupts : The interrupt number > > Optional properties : > -- > 1.8.1.2 >