From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: RAGHAVENDRA GANIGA
<ravi23ganiga-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] i2c: i2c-core: fix coding style issues in i2c-core.c
Date: Tue, 14 Jan 2014 19:38:45 +0100 [thread overview]
Message-ID: <20140114183845.GD10340@katana> (raw)
In-Reply-To: <525C0CDB.6020305-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]
> --- a/drivers/i2c/i2c-core.c
> +++ b/drivers/i2c/i2c-core.c
> @@ -1737,9 +1737,9 @@ int i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
> for (ret = 0; ret < num; ret++) {
> dev_dbg(&adap->dev, "master_xfer[%d] %c, addr=0x%02x, len=%d%s\n",
> ret,
> - ((msgs[ret].flags & I2C_M_RD) ? 'R' : 'W'),
> + msgs[ret].flags & I2C_M_RD ? 'R' : 'W',
> msgs[ret].addr, msgs[ret].len,
> - (msgs[ret].flags & I2C_M_RECV_LEN) ? "+" : "");
> + msgs[ret].flags & I2C_M_RECV_LEN ? "+" : "");
Don't spend time changing too much here like the paranthesis. It will
probably be removed soon in favour of the tracing approach.
> @@ -2120,7 +2120,8 @@ EXPORT_SYMBOL(i2c_smbus_read_byte);
> s32 i2c_smbus_write_byte(const struct i2c_client *client, u8 value)
> {
> return i2c_smbus_xfer(client->adapter, client->addr, client->flags,
> - I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE, NULL);
> + I2C_SMBUS_WRITE, value,
> + I2C_SMBUS_BYTE, NULL);
Not worth the change IMO. Just drop this patch.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-14 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 15:25 [PATCH 3/3] i2c: i2c-core: fix coding style issues in i2c-core.c RAGHAVENDRA GANIGA
[not found] ` <525C0CDB.6020305-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-01-14 18:38 ` Wolfram Sang [this message]
2014-01-14 19:06 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114183845.GD10340@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ravi23ganiga-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).