From: Wolfram Sang <wsa@the-dreams.de>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 30/73] drivers/i2c: busses/i2c-acorn.c is tristate and should use module.h
Date: Fri, 24 Jan 2014 18:26:14 +0100 [thread overview]
Message-ID: <20140124172614.GF2629@katana> (raw)
In-Reply-To: <1390339396-3479-31-git-send-email-paul.gortmaker@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
On Tue, Jan 21, 2014 at 04:22:33PM -0500, Paul Gortmaker wrote:
> This file is controlled by a tristate Kconfig option, and hence
> needs to include module.h so that it can get module_init() once
> we relocate it from init.h into module.h in the future.
>
> Note that module_exit() appears to be missing from the driver, so
> it is questionable whether it would actually work for a removal
> and reload cycle if it was configured for a modular build.
>
> Cc: Wolfram Sang <wsa@the-dreams.de>
> Cc: linux-i2c@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Applied to for-current, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-24 17:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1390339396-3479-1-git-send-email-paul.gortmaker@windriver.com>
2014-01-21 21:22 ` [PATCH 30/73] drivers/i2c: busses/i2c-acorn.c is tristate and should use module.h Paul Gortmaker
2014-01-24 17:26 ` Wolfram Sang [this message]
2014-01-21 21:22 ` [PATCH 51/73] drivers/i2c: delete non-required instances of include <linux/init.h> Paul Gortmaker
[not found] ` <1390339396-3479-52-git-send-email-paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2014-01-24 17:09 ` Jean Delvare
2014-01-24 17:26 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140124172614.GF2629@katana \
--to=wsa@the-dreams.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).