From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH 1/4] i2c: rename Blackfin TWI I2C driver to i2c-adi-twi.c Date: Sun, 26 Jan 2014 11:28:59 +0100 Message-ID: <20140126102859.GA2579@katana> References: <1390720607-447-1-git-send-email-sonic.adi@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BOKacYhQ+x31HxR3" Return-path: Content-Disposition: inline In-Reply-To: <1390720607-447-1-git-send-email-sonic.adi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sonic Zhang Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, adi-buildroot-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Sonic Zhang List-Id: linux-i2c@vger.kernel.org --BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 26, 2014 at 03:16:44PM +0800, Sonic Zhang wrote: > From: Sonic Zhang >=20 > Rename twi arch header as well. You describe what you do, yet the commit message should describe WHY the change is needed. This applies for the other patches as well. >=20 > Signed-off-by: Sonic Zhang What is the difference between the two versions you sent? Please always describe that. --BOKacYhQ+x31HxR3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIcBAEBAgAGBQJS5ONqAAoJEBQN5MwUoCm2S9AQAKnkTeSgN4isVclF2D1f5QRB wz1+Bl2p0edGu0yQ28FFSp8di+FJpj47Ej4PAvn00/C1P4inp2GzDf3//YX9sEIR Acv4V8R+hDgZSkt4EtrOZfIHI2pOgImif2Zqxd1eeSQ5pceYcjBVPNzQ0j4N/Sr1 dPrH3aap9NOMxaGAtna3M/lwAVlnLtoM4qyPt61f2pEAn2HJgdBlImDQuCjD90Ly FJuBqaX4nDzlfw9CawLsvErl3a+PA+3BLVFhV3KXHzuR3FrDBdNm+owjfh5UlKB9 Ztbt7fveaFoel+5pKA1vp3emn9noD5LLlvJcmUU74V1Vns4o8l6tv8hOaywYWa2d lb+SEgfbCy1aQ73eQsOk9HG3WHpO6Ql7g3HUMXpLFf09ueh0Hw5aXuzWfjcNblmj ZP+fHZms1x8/nYppnOu2AhwA4fCEgR7W4vnPveeD+Lbpj2/T3MIEDG+uiDhW+arj Eov/X51lUFojrCY/xTbBMpvdV4bUppqvutK9eeKyXrrjV5kmDd5Og+/bJoGvwXfA iK5yq+VDrznJAJcGSXf0Rj//Ui0Qg0NDLErXplDK1XOT1EVV3ZTaq9FlIIOEW8yx w965x83ZcxTR8kj9Niu/il/vSVJZdqKph+/3jYRmTt1leuPtGRv2AOI1Gf9EN2sM lpyZD8wvBetGlkEhHcLy =3yui -----END PGP SIGNATURE----- --BOKacYhQ+x31HxR3--