From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v2] i2c: nomadik: factor platform data into state container
Date: Tue, 18 Feb 2014 19:35:39 +0100 [thread overview]
Message-ID: <20140218183539.GE18768@katana> (raw)
In-Reply-To: <1391423246-32410-1-git-send-email-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
> - of_property_read_u32(np, "clock-frequency", &pdata->clk_freq);
> + /* Default to 400 kHz if no frequency is given in the node */
> + if (of_property_read_u32(np, "clock-frequency", &nmk->clk_freq))
> + nmk->clk_freq = 400000;
I can't really recommend this. 100kHz is something all devices support,
but, although common, 400 kHz is already an extension of the standard.
Let me know if I should fix this up for you.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-18 18:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 10:27 [PATCH v2] i2c: nomadik: factor platform data into state container Linus Walleij
[not found] ` <1391423246-32410-1-git-send-email-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-02-14 11:03 ` Linus Walleij
2014-02-18 18:35 ` Wolfram Sang [this message]
2014-02-24 8:57 ` Linus Walleij
[not found] ` <CACRpkdZULnOmRL7Qv-3Y_R4Cxo1A3CtgUBLmUKjsaehEZHur2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-02-24 9:13 ` Wolfram Sang
2014-02-26 12:37 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218183539.GE18768@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).