Re: [PATCH v2] i2c: nomadik: factor platform data into state container

[Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]

On Mon, Feb 24, 2014 at 09:57:05AM +0100, Linus Walleij wrote:
> On Tue, Feb 18, 2014 at 7:35 PM, Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> wrote:
> 
> >> -     of_property_read_u32(np, "clock-frequency", &pdata->clk_freq);
> >> +     /* Default to 400 kHz if no frequency is given in the node */
> >> +     if (of_property_read_u32(np, "clock-frequency", &nmk->clk_freq))
> >> +             nmk->clk_freq = 400000;
> >
> > I can't really recommend this. 100kHz is something all devices support,
> > but, although common, 400 kHz is already an extension of the standard.
> >
> > Let me know if I should fix this up for you.
> 
> I think this is done like this because all devices on all Nomadik variants
> out there (Nomadik, Ux500) support 400kHz.
> 
> Buit change it if you prefer, nothing will break, it will just get slower :-)

OK, then I'll change it. There is this idea of parsing "clock-frequency" in
the core somewhen and if so, 100kHz would be the default, for sure.

> I can easily fix that up ipso facto by modifying the device trees to
> state 400kHz for them.

Then lets do it this way.

Thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]