From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: wolfram-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] i2c: Add message transfer tracepoints for SMBUS
Date: Fri, 28 Feb 2014 22:21:35 +0100 [thread overview]
Message-ID: <20140228212134.GC2517@katana> (raw)
In-Reply-To: <11165.1393507178-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
> > Also, the I2C tracing has first 'f' then 'a', that should be consistent,
> > too.
>
> Flags first or address first? Do you have a preference (for both)?
I'd say address first, yet no strong preference.
> > Can we have something like this for 'flags'?
>
> There's a __print_flags() which should work. One thing I'm concerned about
> there is how do we handle more flags being added - does that count as an ABI
> break if the printed format changes?
Not sure, I mean, this is debug output, no?
> SMBus flags are basically the same as I2C flags, right?
Basically, yes.
Thanks,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-02-28 21:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 21:49 [PATCH 1/2] i2c: Add message transfer tracepoints for I2C David Howells
[not found] ` <20140109214954.25590.73057.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2014-01-09 21:50 ` [PATCH 2/2] i2c: Add message transfer tracepoints for SMBUS David Howells
[not found] ` <20140109215002.25590.51609.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2014-02-18 20:54 ` Wolfram Sang
2014-02-27 13:19 ` David Howells
[not found] ` <11165.1393507178-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2014-02-28 21:21 ` Wolfram Sang [this message]
2014-03-06 13:13 ` David Howells
[not found] ` <19542.1394111635-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2014-03-06 13:17 ` Wolfram Sang
2014-03-06 13:38 ` David Howells
2014-03-01 7:48 ` David Howells
2014-01-22 19:09 ` [PATCH 1/2] i2c: Add message transfer tracepoints for I2C Wolfram Sang
2014-02-18 20:33 ` Wolfram Sang
2014-02-27 13:07 ` David Howells
2014-02-28 21:17 ` Wolfram Sang
2014-03-01 7:54 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228212134.GC2517@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org \
--cc=wolfram-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).