* [PATCH V2] i2c: mv64xxx: fix circular Kconfig dependency
@ 2014-03-06 20:32 Wolfram Sang
[not found] ` <1394137975-3903-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2014-03-06 20:32 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA; +Cc: Maxime Ripard, Wolfram Sang
Commit 370136bc67c3 ("i2c: mv64xxx: Add reset deassert call")
introduced:
drivers/video/Kconfig:42:error: recursive dependency detected!
ARCH_SUNXI selects RESET_CONTROLLER anyhow.
Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
---
drivers/i2c/busses/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 70bcad941657..f8162441576f 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -527,8 +527,7 @@ config I2C_MPC
config I2C_MV64XXX
tristate "Marvell mv64xxx I2C Controller"
- depends on (MV64X60 || PLAT_ORION || ARCH_SUNXI)
- select RESET_CONTROLLER
+ depends on MV64X60 || PLAT_ORION || ARCH_SUNXI
help
If you say yes to this option, support will be included for the
built-in I2C interface on the Marvell 64xxx line of host bridges.
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread[parent not found: <1394137975-3903-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>]
* Re: [PATCH V2] i2c: mv64xxx: fix circular Kconfig dependency [not found] ` <1394137975-3903-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> @ 2014-03-07 9:28 ` Maxime Ripard 0 siblings, 0 replies; 2+ messages in thread From: Maxime Ripard @ 2014-03-07 9:28 UTC (permalink / raw) To: Wolfram Sang; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 1281 bytes --] Hi Wolfram, On Thu, Mar 06, 2014 at 09:32:55PM +0100, Wolfram Sang wrote: > Commit 370136bc67c3 ("i2c: mv64xxx: Add reset deassert call") > introduced: > > drivers/video/Kconfig:42:error: recursive dependency detected! > > ARCH_SUNXI selects RESET_CONTROLLER anyhow. > > Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> > --- > drivers/i2c/busses/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 70bcad941657..f8162441576f 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -527,8 +527,7 @@ config I2C_MPC > > config I2C_MV64XXX > tristate "Marvell mv64xxx I2C Controller" > - depends on (MV64X60 || PLAT_ORION || ARCH_SUNXI) > - select RESET_CONTROLLER > + depends on MV64X60 || PLAT_ORION || ARCH_SUNXI I'm not sure it actually works. MV64X60 and PLAT_ORION don't select RESET_CONTROLLER, and the functions won't be declared, resulting in a compilation breakage too. Maybe we can just depend on RESET_CONTROLLER too here, to fix the circular dependency. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-07 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-06 20:32 [PATCH V2] i2c: mv64xxx: fix circular Kconfig dependency Wolfram Sang
[not found] ` <1394137975-3903-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-03-07 9:28 ` Maxime Ripard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).