From: Wolfram Sang <wsa@the-dreams.de>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kevin.z.m.zh@gmail.com,
sunny@allwinnertech.com, shuge@allwinnertech.com,
zhuzhenhua@allwinnertech.com
Subject: Re: [PATCH] i2c: mv64xxx: Fix compilation breakage
Date: Fri, 7 Mar 2014 18:29:49 +0100 [thread overview]
Message-ID: <20140307172949.GL28943@katana> (raw)
In-Reply-To: <20140307171932.GU607@lukather>
[-- Attachment #1: Type: text/plain, Size: 736 bytes --]
> > Another question is... why do we need to check pd->dev.of_node here?
> > If CONFIG_RESET_CONTROLLER is set, we always try to get the reset
> > controller node, so drv_data->rstc is either going to be a valid
> > pointer, or it's going to be an error pointer - neither
> > reset_control_get() nor devm_reset_control_get return NULL.
>
> Hmmm, right. I'll fix this in a later version.
>
> Wolfram, do you want me to respin the patch making use of
> reset_get_optional introduced by Philip in its other mail?
I think I'd prefer both issues fixed with one patch like in "fixing up
reset controller handling".
And you might want to give a Tested- or Reviewed-by tag to Philipp's
patch if you are going to use it.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-07 17:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 14:59 [PATCH] i2c: mv64xxx: Fix compilation breakage Maxime Ripard
[not found] ` <1394204370-22979-1-git-send-email-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-03-07 16:08 ` Russell King - ARM Linux
2014-03-07 17:19 ` Maxime Ripard
2014-03-07 17:29 ` Wolfram Sang [this message]
2014-03-07 17:52 ` Maxime Ripard
2014-03-10 10:58 ` Maxime Ripard
2014-03-10 11:29 ` Russell King - ARM Linux
[not found] ` <20140310112929.GY21483-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2014-03-21 15:49 ` Paul Gortmaker
2014-03-21 19:17 ` Maxime Ripard
2014-03-22 11:11 ` Arnd Bergmann
2014-03-24 9:41 ` Maxime Ripard
2014-03-28 7:48 ` Wolfram Sang
2014-03-24 13:33 ` Wolfram Sang
2014-03-24 14:03 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307172949.GL28943@katana \
--to=wsa@the-dreams.de \
--cc=kevin.z.m.zh@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=maxime.ripard@free-electrons.com \
--cc=shuge@allwinnertech.com \
--cc=sunny@allwinnertech.com \
--cc=zhuzhenhua@allwinnertech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).