Re: [PATCH] i2c: designware-pci: Cleanup driver power management

[Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

On Tue, Feb 04, 2014 at 02:37:07PM +0200, Mika Westerberg wrote:
> The PCI part of the DesignWare I2C driver does a lot of things that are not
> required anymore. For example drivers aren't supposed to handle PCI state
> transitions themselves. This is all provided by the PCI bus core already.
> 
> In addition to that there is no point scheduling RPM suspend on driver's
> idle hook but instead we can use RPM autosuspend for this (which is enabled
> in the driver already).
> 
> As a bonus, this patch also fixes following compile warning which is
> emitted when the driver was compiled without CONFIG_PM_RUNTIME set:
> 
> drivers/i2c/busses/i2c-designware-pcidrv.c:245:12: warning: ‘i2c_dw_pci_runtime_idle’ defined but not used [-Wunused-function]
> 
> Reported-by: xinhui.pan <xinhuix.pan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Reported-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

Applied to for-next, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]