[PATCH] i2c: s3c2410: do not put a default class for the adapter

[PATCH] i2c: s3c2410: do not put a default class for the adapter

[Naveen Krishna Chatradhi]

From: Vincent Palatin <vpalatin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

Avoid adding I2C_CLASS_HWMON and I2C_CLASS_SPD class flags to all
Samsung I2C adapters when the I2C mappings are defined in a device tree.
So the drivers doing an auto-detection by probing busses won't mess-up
sensitive I2C devices or trigger long timeouts on non-functional busses.

Signed-off-by: Vincent Palatin <vpalatin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Reviewed-by: Olof Johansson <olofj-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Tested-by: Vincent Palatin <vpalatin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Reviewed-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
---
 drivers/i2c/busses/i2c-s3c2410.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 684d21e..63bc64c 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1106,7 +1106,8 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
 	i2c->adap.owner   = THIS_MODULE;
 	i2c->adap.algo    = &s3c24xx_i2c_algorithm;
 	i2c->adap.retries = 2;
-	i2c->adap.class   = I2C_CLASS_HWMON | I2C_CLASS_SPD;
+	if (!pdev->dev.of_node)
+		i2c->adap.class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
 	i2c->tx_setup     = 50;
 
 	init_waitqueue_head(&i2c->wait);
-- 
1.7.9.5

Re: [PATCH] i2c: s3c2410: do not put a default class for the adapter

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

On Fri, Feb 07, 2014 at 01:59:55PM +0530, Naveen Krishna Chatradhi wrote:
> From: Vincent Palatin <vpalatin@chromium.org>
> 
> Avoid adding I2C_CLASS_HWMON and I2C_CLASS_SPD class flags to all
> Samsung I2C adapters when the I2C mappings are defined in a device tree.
> So the drivers doing an auto-detection by probing busses won't mess-up
> sensitive I2C devices or trigger long timeouts on non-functional busses.
> 
> Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
> Reviewed-by: Olof Johansson <olofj@chromium.org>
> Tested-by: Vincent Palatin <vpalatin@chromium.org>
> Reviewed-by: Doug Anderson <dianders@chromium.org>

I'd prefer to drop it in favour of this series:

http://lkml.org/lkml/2014/2/10/836


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] i2c: s3c2410: do not put a default class for the adapter

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

On Sat, Feb 15, 2014 at 04:10:39PM +0100, Wolfram Sang wrote:
> On Fri, Feb 07, 2014 at 01:59:55PM +0530, Naveen Krishna Chatradhi wrote:
> > From: Vincent Palatin <vpalatin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> > 
> > Avoid adding I2C_CLASS_HWMON and I2C_CLASS_SPD class flags to all
> > Samsung I2C adapters when the I2C mappings are defined in a device tree.
> > So the drivers doing an auto-detection by probing busses won't mess-up
> > sensitive I2C devices or trigger long timeouts on non-functional busses.
> > 
> > Signed-off-by: Vincent Palatin <vpalatin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> > Reviewed-by: Olof Johansson <olofj-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> > Tested-by: Vincent Palatin <vpalatin-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> > Reviewed-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

Your Signed-off was missing BTW.

> 
> I'd prefer to drop it in favour of this series:
> 
> http://lkml.org/lkml/2014/2/10/836
> 

I'll go ahead and apply my patch.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]