From: Marek Vasut <marex@denx.de>
To: Yao Yuan <yao.yuan@freescale.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"wsa@the-dreams.de" <wsa@the-dreams.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver
Date: Wed, 26 Mar 2014 04:42:42 +0100 [thread overview]
Message-ID: <201403260442.42970.marex@denx.de> (raw)
In-Reply-To: <1e17ce716618472f9a0146c48f20b976@BL2PR03MB338.namprd03.prod.outlook.com>
On Wednesday, March 26, 2014 at 04:08:27 AM, Yao Yuan wrote:
[...]
> > > + i2c_imx->use_dma = false;
> > > + } else if (i2c_imx_dma_request(i2c_imx, (dma_addr_t)phy_addr)) {
> > > + dev_info(&pdev->dev,
> > > + "can't request dma chan, faild use dma.\n");
> > > + i2c_imx->use_dma = false;
> > > + } else {
> > > + i2c_imx->use_dma = true;
> > > + }
> >
> > Can you not just check if i2c_imx->dma is valid pointer or NULL pointer ?
> > Then you won't need a separate variable, for this purpose ... right ?
>
> Sorry and I think what I know is just to check whether it is NULL.
> Then for the second question, maybe there are some other ways, But I think
> it is more tidy and easier understanding for using a separate variable,
> for this purpose.
You are just wasting space and duplicating data, unless I am wrong.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2014-03-26 3:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 1:47 [PATCH v3 0/2] i2c: add DMA support for freescale i2c driver Yuan Yao
[not found] ` <1394675277-24913-1-git-send-email-yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-03-13 1:47 ` [PATCH v3 1/2] " Yuan Yao
[not found] ` <1394675277-24913-2-git-send-email-yao.yuan-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-03-23 3:49 ` Marek Vasut
2014-03-26 3:08 ` Yao Yuan
2014-03-26 3:42 ` Marek Vasut [this message]
[not found] ` <201403260442.42970.marex-ynQEQJNshbs@public.gmane.org>
2014-03-26 5:56 ` Yao Yuan
[not found] ` <cd88de7e04734400b897c0e2bcf07eab-AZ66ij2kwaZYLYlmg7qx2OO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2014-03-26 6:26 ` Marek Vasut
2014-03-26 7:08 ` Yao Yuan
[not found] ` <8984936f9e914442995d79039543cb58-AZ66ij2kwaZYLYlmg7qx2OO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2014-03-26 7:26 ` Marek Vasut
[not found] ` <201403260826.28114.marex-ynQEQJNshbs@public.gmane.org>
2014-04-03 7:37 ` Shawn Guo
2014-03-13 1:47 ` [PATCH v3 2/2] Documentation:add " Yuan Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201403260442.42970.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=shawn.guo@linaro.org \
--cc=wsa@the-dreams.de \
--cc=yao.yuan@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).