From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: re: i2c: nomadik: Convert to devm functions
Date: Wed, 2 Apr 2014 14:14:25 +0300 [thread overview]
Message-ID: <20140402111425.GB23000@mwanda> (raw)
Hello Ulf Hansson,
The patch 9b2b98a3b4de: "i2c: nomadik: Convert to devm functions"
from Feb 18, 2014, leads to the following static checker warning:
drivers/i2c/busses/i2c-nomadik.c:1002 nmk_i2c_probe()
warn: 'dev->virtbase' isn't an ERR_PTR
drivers/i2c/busses/i2c-nomadik.c
999
1000 dev->virtbase = devm_ioremap(&adev->dev, adev->res.start,
1001 resource_size(&adev->res));
1002 if (IS_ERR(dev->virtbase)) {
^^^^^^^^^^^^^^^^^^^^
devm_ioremap() returns a NULL on error the same as ioremap() does.
1003 ret = -ENOMEM;
1004 goto err_no_mem;
1005 }
1006
1007 dev->irq = adev->irq[0];
regards,
dan carpenter
reply other threads:[~2014-04-02 11:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140402111425.GB23000@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).