* re: i2c: nomadik: Convert to devm functions
@ 2014-04-02 11:14 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2014-04-02 11:14 UTC (permalink / raw)
To: ulf.hansson-QSEj5FYQhm4dnm+yROfE0A; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA
Hello Ulf Hansson,
The patch 9b2b98a3b4de: "i2c: nomadik: Convert to devm functions"
from Feb 18, 2014, leads to the following static checker warning:
drivers/i2c/busses/i2c-nomadik.c:1002 nmk_i2c_probe()
warn: 'dev->virtbase' isn't an ERR_PTR
drivers/i2c/busses/i2c-nomadik.c
999
1000 dev->virtbase = devm_ioremap(&adev->dev, adev->res.start,
1001 resource_size(&adev->res));
1002 if (IS_ERR(dev->virtbase)) {
^^^^^^^^^^^^^^^^^^^^
devm_ioremap() returns a NULL on error the same as ioremap() does.
1003 ret = -ENOMEM;
1004 goto err_no_mem;
1005 }
1006
1007 dev->irq = adev->irq[0];
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-04-02 11:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-02 11:14 i2c: nomadik: Convert to devm functions Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).