* [patch] i2c: qup: off by ones in qup_i2c_probe()
@ 2014-04-03 7:22 Dan Carpenter
2014-04-03 8:35 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-04-03 7:22 UTC (permalink / raw)
To: Wolfram Sang
Cc: Grant Likely, Rob Herring, Bjorn Andersson, Andy Gross,
Ivan T. Ivanov, linux-i2c, kernel-janitors
These should ">= ARRAY_SIZE()" instead of "> ARRAY_SIZE()".
Fixes: 10c5a8425968 ('i2c: qup: New bus driver for the Qualcomm QUP I2C controller')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
index c9d5f78..ee40980 100644
--- a/drivers/i2c/busses/i2c-qup.c
+++ b/drivers/i2c/busses/i2c-qup.c
@@ -633,12 +633,12 @@ static int qup_i2c_probe(struct platform_device *pdev)
* associated with each byte written/received
*/
size = QUP_OUTPUT_BLOCK_SIZE(io_mode);
- if (size > ARRAY_SIZE(blk_sizes))
+ if (size >= ARRAY_SIZE(blk_sizes))
return -EIO;
qup->out_blk_sz = blk_sizes[size] / 2;
size = QUP_INPUT_BLOCK_SIZE(io_mode);
- if (size > ARRAY_SIZE(blk_sizes))
+ if (size >= ARRAY_SIZE(blk_sizes))
return -EIO;
qup->in_blk_sz = blk_sizes[size] / 2;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] i2c: qup: off by ones in qup_i2c_probe()
2014-04-03 7:22 [patch] i2c: qup: off by ones in qup_i2c_probe() Dan Carpenter
@ 2014-04-03 8:35 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2014-04-03 8:35 UTC (permalink / raw)
To: Dan Carpenter
Cc: Grant Likely, Rob Herring, Bjorn Andersson, Andy Gross,
Ivan T. Ivanov, linux-i2c, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
On Thu, Apr 03, 2014 at 10:22:54AM +0300, Dan Carpenter wrote:
> These should ">= ARRAY_SIZE()" instead of "> ARRAY_SIZE()".
>
> Fixes: 10c5a8425968 ('i2c: qup: New bus driver for the Qualcomm QUP I2C controller')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Ah, right. I misinterpreted the smatch message, thought it was a false
positive :(
Applied to for-next, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-03 8:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-03 7:22 [patch] i2c: qup: off by ones in qup_i2c_probe() Dan Carpenter
2014-04-03 8:35 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).