From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Westerberg, Mika" Subject: Re: [PATCH] i2c-designware: Mask interrupts during i2c controller enable Date: Fri, 4 Apr 2014 21:16:13 +0300 Message-ID: <20140404181613.GB19349@intel.com> References: <7286EAF50D3F4E4AADE7FEECEBF8B5A537A70E1F@ORSMSX109.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <7286EAF50D3F4E4AADE7FEECEBF8B5A537A70E1F-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Du, Wenkai" Cc: "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Wolfram Sang , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-i2c@vger.kernel.org On Fri, Apr 04, 2014 at 08:05:23PM +0300, Du, Wenkai wrote: > diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/busses/i2c-designware-core.c > index 14c4b30..71a3fa9 100644 > --- a/drivers/i2c/busses/i2c-designware-core.c > +++ b/drivers/i2c/busses/i2c-designware-core.c > @@ -417,6 +417,9 @@ static void i2c_dw_xfer_init(struct dw_i2c_dev *dev) > */ > dw_writel(dev, msgs[dev->msg_write_idx].addr | ic_tar, DW_IC_TAR); > > + /* disable interrupts */ > + i2c_dw_disable_int(dev); > + Please move this to i2c_dw_init() as I previously commented. This can only happen once the controller comes out of reset (either boot, or resume from system sleep). > /* Enable the adapter */ > __i2c_dw_enable(dev, true); > > -- > 1.7.9.5