From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Westerberg, Mika" Subject: Re: [PATCH] i2c-designware: Mask interrupts during i2c controller enable Date: Sat, 5 Apr 2014 09:13:16 +0300 Message-ID: <20140405061316.GF19349@intel.com> References: <7286EAF50D3F4E4AADE7FEECEBF8B5A537A70E1F@ORSMSX109.amr.corp.intel.com> <20140404181613.GB19349@intel.com> <7286EAF50D3F4E4AADE7FEECEBF8B5A537A70F8B@ORSMSX109.amr.corp.intel.com> <20140404184232.GC19349@intel.com> <7286EAF50D3F4E4AADE7FEECEBF8B5A537A71351@ORSMSX109.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <7286EAF50D3F4E4AADE7FEECEBF8B5A537A71351-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Du, Wenkai" Cc: "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Wolfram Sang , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-i2c@vger.kernel.org On Sat, Apr 05, 2014 at 12:54:33AM +0300, Du, Wenkai wrote: > >Interrupt masking is done already after each transaction. > > At end of transfer, the code uses __i2c_dw_enable(dev, false) to disable > adapter. This function doesn't mask interrupts. There is another function > i2c_dw_disable that masks and clears interrupts. This could be used, but > that means we need to fix in 2 places: Please check i2c_dw_isr() and tell me in which code path interrupts are not getting masked. Or am I missing something fundamental here? In case of abort, we mask interrupts. Also whenever the transaction completes we mask interrupts (in i2c_dw_xfer_msg()). Only place where we didn't do that, as far as I can tell, is right after reset because of the HW default value that unmasks most of them.