From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [Resend Patch 7/9] I2C/ACPI: Add i2c ACPI operation region support Date: Wed, 23 Apr 2014 10:28:39 +0300 Message-ID: <20140423072839.GT30677@intel.com> References: <1397654682-7094-1-git-send-email-tianyu.lan@intel.com> <1398147855-9868-1-git-send-email-tianyu.lan@intel.com> <1398147855-9868-8-git-send-email-tianyu.lan@intel.com> <20140422113638.GK30677@intel.com> <53571D11.3070808@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <53571D11.3070808@intel.com> Sender: linux-acpi-owner@vger.kernel.org To: Lan Tianyu Cc: wsa@the-dreams.de, rjw@rjwysocki.net, awilliam@redhat.com, lenb@kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org List-Id: linux-i2c@vger.kernel.org On Wed, Apr 23, 2014 at 09:53:21AM +0800, Lan Tianyu wrote: > Hi Mika: > Thanks a lot for your review. >=20 > On 2014=E5=B9=B404=E6=9C=8822=E6=97=A5 19:36, Mika Westerberg wrote: > >> > + > >> > + client.adapter =3D adapter; > >> > + client.addr =3D sb->slave_address; > >> > + client.flags =3D 0; > > I'm not sure if this is the correct way to use struct i2c_client > > (allocating it from stack and passing forward to functions that mig= ht > > expect a real i2c_client structure). It has ->dev and all. >=20 > I check all i2c_smbus_xxx helper functions and they are simple wrappe= rs > of i2c_smbus_xfer(). Only adapter, addr and flags of struct client ar= e > used in these functions. In that case I suppose it is OK to (ab)use the client structure like th= is. I think you still want to initialize the whole structure (unused fields with zero) before passing it to the wrappers. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html