linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Fugang Duan <B38611-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: b20596-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
	shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: imx: fix the i2c bus hang issue when do repeat restart
Date: Mon, 2 Jun 2014 17:54:52 +0200	[thread overview]
Message-ID: <20140602155451.GD2654@katana> (raw)
In-Reply-To: <1398839098-6907-1-git-send-email-B38611-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]

On Wed, Apr 30, 2014 at 02:24:58PM +0800, Fugang Duan wrote:
> Test i2c device Maxim max44009, datasheet is located at:
> http://www.maximintegrated.com/datasheet/index.mvp/id/7175
> 
> The max44009 support repeat operation like:
> read -> repeat restart -> read/write
> 
> The current i2c imx host controller driver don't support this
> operation that causes i2c bus hang due to "MTX" is cleared in
> .i2c_imx_read(). If "read" is the last message there have no problem,
> so the current driver supports all SMbus operation like:
> write -> repeat restart -> read/write
> 
> IMX i2c controller for master receiver has some limitation:
> - If it is the last byte for one operation, it must generate STOP
>   signal before read I2DR to prevent controller from generating another
>   clock cycle.
> - If it is the last byte in the read, and then do repeat restart, it must
>   set "MTX" before read I2DR to prevent controller from generating another
>   extra clock cycle.
> 
> The patch is to fix the issue.
> 
> Signed-off-by: Fugang Duan <B38611-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

Applied to for-next, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      parent reply	other threads:[~2014-06-02 15:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30  6:24 [PATCH] i2c: imx: fix the i2c bus hang issue when do repeat restart Fugang Duan
     [not found] ` <1398839098-6907-1-git-send-email-B38611-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-06-02 15:54   ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140602155451.GD2654@katana \
    --to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
    --cc=B38611-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=b20596-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).