* [PATCH] i2c: sun6-p2wi: fix erroneous error message
[not found] ` <53994cdd.dj2lZ0lrPyPuIr9Z%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
@ 2014-06-12 7:32 ` Boris BREZILLON
[not found] ` <1402558321-18981-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Boris BREZILLON @ 2014-06-12 7:32 UTC (permalink / raw)
To: kbuild test robot, Wolfram Sang
Cc: Maxime Ripard, Shuge, kevin-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-i2c-u79uwXL29TY76Z2rM5mHXA, Boris BREZILLON
The variable containing the return value of platform_get_irq is irq not
ret, this means the error code printed in the error message will be false.
Signed-off-by: Boris BREZILLON <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Reported-by: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
Hello Wolfram,
This patch fixes a bug reported by Fengguang's build robot.
I know you've already applied my series to your for-next tree, but let me
know if you want me to squash this patch into the P2WI series and send a v8.
Best Regards,
Boris
drivers/i2c/busses/i2c-sun6i-p2wi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c
index f1d3e6f..5d2d678 100644
--- a/drivers/i2c/busses/i2c-sun6i-p2wi.c
+++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c
@@ -240,7 +240,7 @@ static int p2wi_probe(struct platform_device *pdev)
snprintf(p2wi->adapter.name, sizeof(p2wi->adapter.name), pdev->name);
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(dev, "failed to retrieve irq: %d\n", ret);
+ dev_err(dev, "failed to retrieve irq: %d\n", irq);
return irq;
}
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread