linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: "Lothar Waßmann" <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
	linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	adi-buildroot-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 00/16] i2c: drop class based instantiaion for selected drivers
Date: Thu, 10 Jul 2014 15:13:07 +0200	[thread overview]
Message-ID: <20140710131307.GI2728@katana> (raw)
In-Reply-To: <20140710143837.558c1d07-VjFSrY7JcPWvSplVBqRQBQ@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]


> > +	/* Warn that the adapter lost class based instantiation */
> > +	if (adapter->class == I2C_CLASS_DEPRECATED) {
> > +		dev_dbg(&adapter->dev,
> > +			"This adapter dropped support for I2C classes and "
> > +			"won't auto-detect %s devices anymore. If you need it, check "
> > +			"'Documentation/i2c/instantiating-devices' for alternatives.\n",
> >
> It's usually a bad idea to split kernel messages across source lines

Yes, "usually". Not for this message, though, it's specific. The lines
would have been quite long.

> You could at least do the split at the sentence boundary.

OK, this would have been a compromise.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2014-07-10 13:13 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-10 11:46 [PATCH 00/16] i2c: drop class based instantiaion for selected drivers Wolfram Sang
2014-07-10 11:46 ` [PATCH 01/16] i2c: add debug info when class instantiation was dropped Wolfram Sang
2014-07-10 11:46 ` [PATCH 02/16] i2c: i2c-at91: Drop class based scanning to improve bootup time Wolfram Sang
2014-07-17 15:27   ` Ludovic Desroches
2014-07-10 11:46 ` [PATCH 03/16] i2c: i2c-bcm2835: " Wolfram Sang
2014-07-10 11:46 ` [PATCH 04/16] i2c: i2c-bfin-twi: " Wolfram Sang
     [not found] ` <1404992799-3705-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-07-10 11:46   ` [PATCH 05/16] i2c: i2c-davinci: " Wolfram Sang
2014-07-10 12:38   ` [PATCH 00/16] i2c: drop class based instantiaion for selected drivers Lothar Waßmann
     [not found]     ` <20140710143837.558c1d07-VjFSrY7JcPWvSplVBqRQBQ@public.gmane.org>
2014-07-10 13:13       ` Wolfram Sang [this message]
2014-07-10 11:46 ` [PATCH 06/16] i2c: i2c-designware-platdrv: Drop class based scanning to improve bootup time Wolfram Sang
2014-07-10 11:46 ` [PATCH 07/16] i2c: i2c-mv64xxx: " Wolfram Sang
2014-07-21 13:33   ` Andrew Lunn
2014-07-10 11:46 ` [PATCH 08/16] i2c: i2c-nomadik: " Wolfram Sang
     [not found]   ` <1404992799-3705-9-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-07-10 14:35     ` Linus Walleij
2014-07-10 11:46 ` [PATCH 09/16] i2c: i2c-ocores: " Wolfram Sang
     [not found]   ` <1404992799-3705-10-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-07-10 14:32     ` Peter Korsgaard
2014-07-10 11:46 ` [PATCH 10/16] i2c: i2c-omap: " Wolfram Sang
2014-07-10 11:46 ` [PATCH 11/16] i2c: i2c-rcar: " Wolfram Sang
2014-07-10 11:46 ` [PATCH 12/16] i2c: i2c-s3c2410: " Wolfram Sang
2014-07-11  5:59   ` Sachin Kamat
2014-07-10 11:46 ` [PATCH 13/16] i2c: i2c-sirf: " Wolfram Sang
2014-07-10 11:46 ` [PATCH 14/16] i2c: i2c-stu300: " Wolfram Sang
2014-07-10 14:35   ` Linus Walleij
2014-07-10 11:46 ` [PATCH 15/16] i2c: i2c-tegra: " Wolfram Sang
     [not found]   ` <1404992799-3705-16-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-07-10 12:34     ` Mikko Perttunen
2014-07-10 13:43     ` Thierry Reding
2014-07-10 11:46 ` [PATCH 16/16] i2c: i2c-xiic: " Wolfram Sang
2014-07-16 17:46 ` [PATCH 00/16] i2c: drop class based instantiaion for selected drivers Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140710131307.GI2728@katana \
    --to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
    --cc=LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org \
    --cc=adi-buildroot-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).