From: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
To: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
Cc: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/2] i2c-stub: Add support for banked register ranges
Date: Thu, 10 Jul 2014 11:40:36 -0700 [thread overview]
Message-ID: <20140710184036.GA6950@roeck-us.net> (raw)
In-Reply-To: <20140710125659.015f1517-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
On Thu, Jul 10, 2014 at 12:56:59PM +0200, Jean Delvare wrote:
> Some chips implement banked register ranges. This allows implementing
> more registers than the limited 8-bit address space originally allows.
> In order to access a register on these chips, you must first select
> the proper bank. Add support for this mechanism to the i2c-stub driver
> so that such chips can be emulated. All the bank settings are passed
> as module parameters.
>
> Signed-off-by: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
> Cc: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
> ---
> Tested successfully with:
> http://jdelvare.nerim.net/devel/lm-sensors/dumps/w83793-for-stub.dump
>
Also with NCT7802Y.
Tested-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Would it make sense to use devm_ functions for memory allocations ?
That would simplify cleanup.
Thanks,
Guenter
next prev parent reply other threads:[~2014-07-10 18:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 10:45 [PATCH 1/2] i2c-stub: Remember the number of emulated chips Jean Delvare
[not found] ` <20140710124511.05108894-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2014-07-10 10:56 ` [PATCH 2/2] i2c-stub: Add support for banked register ranges Jean Delvare
[not found] ` <20140710125659.015f1517-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2014-07-10 18:40 ` Guenter Roeck [this message]
[not found] ` <20140710184036.GA6950-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2014-07-10 21:30 ` Jean Delvare
[not found] ` <20140710233040.59d1dfea-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2014-07-10 22:18 ` Guenter Roeck
2014-07-11 4:27 ` Guenter Roeck
2014-07-17 17:18 ` Wolfram Sang
2014-07-10 12:14 ` [PATCH 1/2] i2c-stub: Remember the number of emulated chips Guenter Roeck
2014-07-17 17:15 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710184036.GA6950@roeck-us.net \
--to=linux-0h96xk9xttrk1umjsbkqmq@public.gmane.org \
--cc=jdelvare-l3A5Bk7waGM@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).