From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH 2/2] i2c-stub: Add support for banked register ranges Date: Thu, 10 Jul 2014 23:30:40 +0200 Message-ID: <20140710233040.59d1dfea@endymion.delvare> References: <20140710124511.05108894@endymion.delvare> <20140710125659.015f1517@endymion.delvare> <20140710184036.GA6950@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140710184036.GA6950-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Guenter Roeck Cc: Linux I2C List-Id: linux-i2c@vger.kernel.org On Thu, 10 Jul 2014 11:40:36 -0700, Guenter Roeck wrote: > On Thu, Jul 10, 2014 at 12:56:59PM +0200, Jean Delvare wrote: > > Some chips implement banked register ranges. This allows implementing > > more registers than the limited 8-bit address space originally allows. > > In order to access a register on these chips, you must first select > > the proper bank. Add support for this mechanism to the i2c-stub driver > > so that such chips can be emulated. All the bank settings are passed > > as module parameters. > > > > Signed-off-by: Jean Delvare > > Cc: Guenter Roeck > > --- > > Tested successfully with: > > http://jdelvare.nerim.net/devel/lm-sensors/dumps/w83793-for-stub.dump > > > Also with NCT7802Y. > > Tested-by: Guenter Roeck Thanks. > Would it make sense to use devm_ functions for memory allocations ? > That would simplify cleanup. Sure, no objection from me. -- Jean Delvare SUSE L3 Support