linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: i2c,designware: add new bindings
Date: Fri, 1 Aug 2014 19:52:31 +0200	[thread overview]
Message-ID: <20140801175230.GD3277@katana> (raw)
In-Reply-To: <1406117217.2895.12.camel-wU3TRTJX3O1FGiH78xh5akvbDziVy8sZEvhb3Hwu1Ks@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 2094 bytes --]

Hi Alan,

On Wed, Jul 23, 2014 at 01:06:57PM +0100, Alan Cox wrote:
> This may appear as PCI or ACPI depending upon the firmware so we
> have to list both. All share the same ACPI identifier but not
> the same PCI identifier.
> 
> Signed-off-by: Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> ---
>  drivers/i2c/busses/i2c-designware-pcidrv.c  |    9 +++++++++
>  drivers/i2c/busses/i2c-designware-platdrv.c |    1 +
>  2 files changed, 10 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
> index 3356f7a..d31d313 100644
> --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> @@ -188,6 +188,7 @@ static struct  dw_pci_controller dw_pci_controllers[] = {
>  		.scl_sda_cfg = &hsw_config,
>  	},
>  };
> +
>  static struct i2c_algorithm i2c_dw_algo = {
>  	.master_xfer	= i2c_dw_xfer,
>  	.functionality	= i2c_dw_func,
> @@ -350,6 +351,14 @@ static const struct pci_device_id i2_designware_pci_ids[] = {
>  	/* Haswell */
>  	{ PCI_VDEVICE(INTEL, 0x9c61), haswell },
>  	{ PCI_VDEVICE(INTEL, 0x9c62), haswell },
> +	/* Braswell / Cherrytrail */
> +	{ PCI_VDEVICE(INTEL, 0x22C1), baytrail,},
> +	{ PCI_VDEVICE(INTEL, 0x22C2), baytrail },
> +	{ PCI_VDEVICE(INTEL, 0x22C3), baytrail },
> +	{ PCI_VDEVICE(INTEL, 0x22C4), baytrail },
> +	{ PCI_VDEVICE(INTEL, 0x22C5), baytrail },
> +	{ PCI_VDEVICE(INTEL, 0x22C6), baytrail },
> +	{ PCI_VDEVICE(INTEL, 0x22C7), baytrail },
>  	{ 0,}
>  };
>  MODULE_DEVICE_TABLE(pci, i2_designware_pci_ids);
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index 402ec39..915ce6c2 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -106,6 +106,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
>  	{ "INT3432", 0 },
>  	{ "INT3433", 0 },
>  	{ "80860F41", 0 },
> +	{ "808622C1", 0 },

Why are 22c2 up to 22c7 not added here?

Thanks,

   Wolfram

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2014-08-01 17:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-23 12:06 i2c,designware: add new bindings Alan Cox
     [not found] ` <1406117217.2895.12.camel-wU3TRTJX3O1FGiH78xh5akvbDziVy8sZEvhb3Hwu1Ks@public.gmane.org>
2014-08-01 17:52   ` Wolfram Sang [this message]
2014-08-01 18:09     ` Alan Cox
     [not found]       ` <1406916581.30675.3.camel-wU3TRTJX3O1FGiH78xh5akvbDziVy8sZEvhb3Hwu1Ks@public.gmane.org>
2014-08-02 11:14         ` Wolfram Sang
2014-08-02 11:21   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140801175230.GD3277@katana \
    --to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
    --cc=alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).