From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH 1/14] i2c: mpc: delete unneeded test before of_node_put Date: Fri, 8 Aug 2014 12:25:36 +0200 Message-ID: <20140808102536.GZ1933@pengutronix.de> References: <1407492475-26283-1-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1407492475-26283-1-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Julia Lawall Cc: Wolfram Sang , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org Hello, On Fri, Aug 08, 2014 at 12:07:42PM +0200, Julia Lawall wrote: > From: Julia Lawall >=20 > Of_node_put supports NULL as its argument, so the initial test is not > necessary. >=20 > Suggested by Uwe Kleine-K=F6nig. Thanks for picking up my suggestion. > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) >=20 > // > @@ > expression e; > @@ >=20 > -if (e) > of_node_put(e); > // >=20 I added devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org to Cc. Maybe they want to comment th= e series? If it's acceptable the logical next step is to add the patch to the collection of semantic patches, right? Best regards Uwe > Signed-off-by: Julia Lawall >=20 > --- > drivers/i2c/busses/i2c-mpc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mp= c.c > index 6a32aa0..0edf630 100644 > --- a/drivers/i2c/busses/i2c-mpc.c > +++ b/drivers/i2c/busses/i2c-mpc.c > @@ -341,8 +341,7 @@ static u32 mpc_i2c_get_sec_cfg_8xxx(void) > iounmap(reg); > } > } > - if (node) > - of_node_put(node); > + of_node_put(node); > =20 > return val; > } >=20 >=20 --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= |