From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
Subject: Re: [PATCH] ARM: shmobile: koelsch: Remove non-existent i2c6 pinmux
Date: Wed, 13 Aug 2014 17:04:14 +0900
Message-ID: <20140813080412.GA4410@verge.net.au>
References: <1407848593-23040-1-git-send-email-geert+renesas@glider.be>
 <20140812133622.GC10875@verge.net.au>
 <CAMuHMdXif88Tdo-4doF=B6x5zdrcP8banSLOBVgZd59_EEXspA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <CAMuHMdXif88Tdo-4doF=B6x5zdrcP8banSLOBVgZd59_EEXspA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
To: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Cc: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>, Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>, Gaku Inami <gaku.inami.xw-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>, Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux-sh list <linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
List-Id: linux-i2c@vger.kernel.org

On Tue, Aug 12, 2014 at 03:48:12PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Tue, Aug 12, 2014 at 3:36 PM, Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> wrote:
> > On Tue, Aug 12, 2014 at 03:03:13PM +0200, Geert Uytterhoeven wrote:
> >> On r8a7791, i2c6 (aka iic3) doesn't need pinmux, but the koelsch dts
> >> refers to non-existent pinmux configuration data:
> >>
> >> pinmux core: sh-pfc does not support function i2c6
> >> sh-pfc e6060000.pfc: invalid function i2c6 in map table
> >>
> >> Remove it to fix this.
> >>
> >> Fixes: commit 1d41f36a68c0f4e9b01d563ce33bab5201858b54 ("ARM: shmobile:
> >>        koelsch dts: Add VDD MPU regulator for DVFS")
> >> Signed-off-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
> >
> > Thanks Geert. Does this manifest as a run-time problem?
> 
> I don't think it causes any harm, despite the error message.
> i2c6 works fine (using a modified version of "ARM: shmobile:
> koelsch-reference: Add restart function" from the BSP).
> 
> > Regardless, it looks like I should queue this up as
> > a fix for v3.17. Is that your thinking too?
> 
> The error message is a regression from v3.16, so v3.17 would be
> appropriate. However, if you have no other DTS fixes for v3.17,
> v3.18 is fine for me, too.

I don't have any other fixes pending at this time.
But sending this one to the arm-soc guys should not
be much of a burden.