From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: "Janusz Użycki" <j.uzycki-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Subject: Re: [PATCH 1/2] i2c-mxs: fixed error message in pio transfer
Date: Tue, 9 Sep 2014 14:36:07 +0200 [thread overview]
Message-ID: <201409091436.08028.marex@denx.de> (raw)
In-Reply-To: <540EB762.8090509-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org>
On Tuesday, September 09, 2014 at 10:16:34 AM, Janusz Użycki wrote:
> W dniu 2014-09-08 20:14, Marek Vasut pisze:
> > On Monday, September 08, 2014 at 08:04:22 PM, Janusz Użycki wrote:
> >
> > Thanks, but the Subject of the email doesn't make much sense. Also, a
> > short commit message exlaining what you did and why you did it would be
> > nice.
> >
> > While the patch is obvious and obviously correct, can you please fix
> > those two minor things ?
>
> i2c-mxs: fixed error message in pio transfer
>
> If I2C_M_RD flag is set SELECT command is sent
> and afterward READ command.
> The patch fixes READ command to return READ failure error message
> instead of SELECT failure error message.
>
> >> Signed-off-by: Janusz Uzycki <j.uzycki-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org>
> >> ---
> >>
> >> linux-3.14.17/drivers/i2c/busses/i2c-mxs.c | 2 +-
> >
> > btw. how did this 'linux-3.14.17' get in the path ?
>
> I have some scripts in my repo and I forgot about longer patch.
Can you please repost the patches using git send-email ?
Thanks!
Best regards,
Marek Vasut
prev parent reply other threads:[~2014-09-09 12:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 18:04 [PATCH 1/2] i2c-mxs: debug error message: second SELECT -> READ Janusz Użycki
[not found] ` <540DEFA6.9030600-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org>
2014-09-08 18:06 ` [PATCH 2/2] i2c-mxs: fixed PIO NACK error instead of timeout Janusz Użycki
[not found] ` <540DF014.5000508-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org>
2014-09-08 18:33 ` Marek Vasut
[not found] ` <201409082033.58959.marex-ynQEQJNshbs@public.gmane.org>
2014-09-09 9:27 ` Janusz Użycki
[not found] ` <540EC808.6060407-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org>
2014-09-09 12:48 ` Marek Vasut
[not found] ` <201409091448.40115.marex-ynQEQJNshbs@public.gmane.org>
2014-09-09 13:10 ` Janusz Użycki
[not found] ` <540EFC41.9070106-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org>
2014-09-09 13:59 ` Marek Vasut
[not found] ` <201409091559.24900.marex-ynQEQJNshbs@public.gmane.org>
2014-09-09 15:05 ` Janusz Użycki
[not found] ` <540F1734.6090700-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org>
2014-09-09 18:59 ` Marek Vasut
2014-09-08 18:14 ` [PATCH 1/2] i2c-mxs: debug error message: second SELECT -> READ Marek Vasut
[not found] ` <201409082014.07749.marex-ynQEQJNshbs@public.gmane.org>
2014-09-09 8:16 ` [PATCH 1/2] i2c-mxs: fixed error message in pio transfer Janusz Użycki
[not found] ` <540EB762.8090509-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org>
2014-09-09 12:36 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201409091436.08028.marex@denx.de \
--to=marex-ynqeqjnshbs@public.gmane.org \
--cc=j.uzycki-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).