From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v4 1/3] mfd: add support for Diolan DLN-2 devices Date: Wed, 17 Sep 2014 08:46:53 -0700 Message-ID: <20140917154653.GF30918@lee--X1> References: <1410290686-6680-1-git-send-email-octavian.purdila@intel.com> <1410290686-6680-2-git-send-email-octavian.purdila@intel.com> <20140917091001.GF20727@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20140917091001.GF20727@localhost> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Johan Hovold Cc: Octavian Purdila , gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, daniel.baluta-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, laurentiu.palcu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Wed, 17 Sep 2014, Johan Hovold wrote: > On Tue, Sep 09, 2014 at 10:24:44PM +0300, Octavian Purdila wrote: > > This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO > > Master Adapter DLN-2. Details about the device can be found here: > >=20 > > https://www.diolan.com/i2c/i2c_interface.html. > >=20 > > Information about the USB protocol can be found in the Programmer's > > Reference Manual [1], see section 1.7. > >=20 > > Because the hardware has a single transmit endpoint and a single > > receive endpoint the communication between the various DLN2 drivers > > and the hardware will be muxed/demuxed by this driver. > >=20 > > Each DLN2 module will be identified by the handle field within the = DLN2 > > message header. If a DLN2 module issues multiple commands in parall= el > > they will be identified by the echo counter field in the message he= ader. > >=20 > > The DLN2 modules can use the dln2_transfer() function to issue a > > command and wait for its response. They can also register a callbac= k > > that is going to be called when a specific event id is generated by > > the device (e.g. GPIO interrupts). The device uses handle 0 for > > sending events. > >=20 > > [1] https://www.diolan.com/downloads/dln-api-manual.pdf > >=20 > > Signed-off-by: Octavian Purdila > > --- > > drivers/mfd/Kconfig | 9 + > > drivers/mfd/Makefile | 1 + > > drivers/mfd/dln2.c | 681 +++++++++++++++++++++++++++++++++++= ++++++++++++ > > include/linux/mfd/dln2.h | 71 +++++ > > 4 files changed, 762 insertions(+) > > create mode 100644 drivers/mfd/dln2.c > > create mode 100644 include/linux/mfd/dln2.h [...] > Unless anyone suggests otherwise (e.g. to stick with auto id), I'll a= dd > a helper function for this and fix up those two drivers. Appreciated. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html