* i2c-core.ko renamed to i2ccore.ko
@ 2014-09-18 12:17 Jean Delvare
[not found] ` <1411042678.7338.20.camel-H7Kp9ZFCxt/N0uC3ymp8PA@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Jean Delvare @ 2014-09-18 12:17 UTC (permalink / raw)
To: Lan Tianyu, Wolfram Sang, Mika Westerberg; +Cc: Linux I2C
Hi guys,
Sorry for jumping in a bit late, but given that I did not get involved
in the discussions that led to this decision, better late than never.
I almost had an heart attack when noticing that module i2c-core.ko has
suddenly been renamed to i2ccore.ko without an hyphen.
Renaming kernel modules is almost always wrong, in particular subsystem
core modules. Such renames have an impact at various levels. We just had
to change a configuration file in the openSUSE Factory kernel to adjust
that change, and this is how I noticed it. But there can be several
other issues, including mkinitrd or equivalent tools, as well as
documentation. The extra work and confusion is a high price to pay, and
it can easily be avoided.
So I am kindly asking that you revert this name change before kernel
v3.17 final. Rename source files if you really have to, git makes it
easy. Or merge the i2c-acpi.c code into i2c-core.c with ifdefs. Or
whatever. Just don't rename i2c-core.ko, please.
Thanks,
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: i2c-core.ko renamed to i2ccore.ko
[not found] ` <1411042678.7338.20.camel-H7Kp9ZFCxt/N0uC3ymp8PA@public.gmane.org>
@ 2014-09-18 12:58 ` Mika Westerberg
[not found] ` <20140918125825.GR10854-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Mika Westerberg @ 2014-09-18 12:58 UTC (permalink / raw)
To: Jean Delvare; +Cc: Lan Tianyu, Wolfram Sang, Linux I2C
On Thu, Sep 18, 2014 at 02:17:58PM +0200, Jean Delvare wrote:
> Hi guys,
>
> Sorry for jumping in a bit late, but given that I did not get involved
> in the discussions that led to this decision, better late than never.
>
> I almost had an heart attack when noticing that module i2c-core.ko has
> suddenly been renamed to i2ccore.ko without an hyphen.
>
> Renaming kernel modules is almost always wrong, in particular subsystem
> core modules. Such renames have an impact at various levels. We just had
> to change a configuration file in the openSUSE Factory kernel to adjust
> that change, and this is how I noticed it. But there can be several
> other issues, including mkinitrd or equivalent tools, as well as
> documentation. The extra work and confusion is a high price to pay, and
> it can easily be avoided.
I understand completely your point and I guess this was rather
inadvertent change.
> So I am kindly asking that you revert this name change before kernel
> v3.17 final. Rename source files if you really have to, git makes it
> easy. Or merge the i2c-acpi.c code into i2c-core.c with ifdefs. Or
> whatever. Just don't rename i2c-core.ko, please.
My vote goes for merging i2c-acpi.c back to i2c-core.c with #ifdefs.
Tianyu, Wolfram, comments?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: i2c-core.ko renamed to i2ccore.ko
[not found] ` <20140918125825.GR10854-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
@ 2014-09-18 15:10 ` Wolfram Sang
2014-09-19 8:28 ` Lan Tianyu
0 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2014-09-18 15:10 UTC (permalink / raw)
To: Mika Westerberg; +Cc: Jean Delvare, Lan Tianyu, Linux I2C
[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]
On Thu, Sep 18, 2014 at 03:58:57PM +0300, Mika Westerberg wrote:
> On Thu, Sep 18, 2014 at 02:17:58PM +0200, Jean Delvare wrote:
> > Hi guys,
> >
> > Sorry for jumping in a bit late, but given that I did not get involved
> > in the discussions that led to this decision, better late than never.
> >
> > I almost had an heart attack when noticing that module i2c-core.ko has
> > suddenly been renamed to i2ccore.ko without an hyphen.
> >
> > Renaming kernel modules is almost always wrong, in particular subsystem
> > core modules. Such renames have an impact at various levels. We just had
> > to change a configuration file in the openSUSE Factory kernel to adjust
> > that change, and this is how I noticed it. But there can be several
> > other issues, including mkinitrd or equivalent tools, as well as
> > documentation. The extra work and confusion is a high price to pay, and
> > it can easily be avoided.
>
> I understand completely your point and I guess this was rather
> inadvertent change.
Yes. Thanks for pointing out, Jean!
>
> > So I am kindly asking that you revert this name change before kernel
> > v3.17 final. Rename source files if you really have to, git makes it
> > easy. Or merge the i2c-acpi.c code into i2c-core.c with ifdefs. Or
> > whatever. Just don't rename i2c-core.ko, please.
>
> My vote goes for merging i2c-acpi.c back to i2c-core.c with #ifdefs.
>
> Tianyu, Wolfram, comments?
Agreed.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: i2c-core.ko renamed to i2ccore.ko
2014-09-18 15:10 ` Wolfram Sang
@ 2014-09-19 8:28 ` Lan Tianyu
[not found] ` <541BE912.6060905-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Lan Tianyu @ 2014-09-19 8:28 UTC (permalink / raw)
To: Wolfram Sang, Mika Westerberg; +Cc: Jean Delvare, Linux I2C
On 2014年09月18日 23:10, Wolfram Sang wrote:
> On Thu, Sep 18, 2014 at 03:58:57PM +0300, Mika Westerberg wrote:
>> On Thu, Sep 18, 2014 at 02:17:58PM +0200, Jean Delvare wrote:
>>> Hi guys,
>>>
>>> Sorry for jumping in a bit late, but given that I did not get involved
>>> in the discussions that led to this decision, better late than never.
>>>
>>> I almost had an heart attack when noticing that module i2c-core.ko has
>>> suddenly been renamed to i2ccore.ko without an hyphen.
>>>
>>> Renaming kernel modules is almost always wrong, in particular subsystem
>>> core modules. Such renames have an impact at various levels. We just had
>>> to change a configuration file in the openSUSE Factory kernel to adjust
>>> that change, and this is how I noticed it. But there can be several
>>> other issues, including mkinitrd or equivalent tools, as well as
>>> documentation. The extra work and confusion is a high price to pay, and
>>> it can easily be avoided.
>>
>> I understand completely your point and I guess this was rather
>> inadvertent change.
>
> Yes. Thanks for pointing out, Jean!
>
>>
>>> So I am kindly asking that you revert this name change before kernel
>>> v3.17 final. Rename source files if you really have to, git makes it
>>> easy. Or merge the i2c-acpi.c code into i2c-core.c with ifdefs. Or
>>> whatever. Just don't rename i2c-core.ko, please.
>>
>> My vote goes for merging i2c-acpi.c back to i2c-core.c with #ifdefs.
>>
>> Tianyu, Wolfram, comments?
>
> Agreed.
>
How about including i2c-acpi.c in the i2c-core.c directly if ACPI is
selected?
--
Best regards
Tianyu Lan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: i2c-core.ko renamed to i2ccore.ko
[not found] ` <541BE912.6060905-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
@ 2014-09-19 8:53 ` Mika Westerberg
[not found] ` <20140919085328.GC10854-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Mika Westerberg @ 2014-09-19 8:53 UTC (permalink / raw)
To: Lan Tianyu; +Cc: Wolfram Sang, Jean Delvare, Linux I2C
On Fri, Sep 19, 2014 at 04:28:02PM +0800, Lan Tianyu wrote:
> How about including i2c-acpi.c in the i2c-core.c directly if ACPI is
> selected?
I would rather see it merged there.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: i2c-core.ko renamed to i2ccore.ko
[not found] ` <20140919085328.GC10854-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
@ 2014-09-20 9:02 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2014-09-20 9:02 UTC (permalink / raw)
To: Mika Westerberg; +Cc: Lan Tianyu, Jean Delvare, Linux I2C
[-- Attachment #1: Type: text/plain, Size: 267 bytes --]
On Fri, Sep 19, 2014 at 11:53:28AM +0300, Mika Westerberg wrote:
> On Fri, Sep 19, 2014 at 04:28:02PM +0800, Lan Tianyu wrote:
> > How about including i2c-acpi.c in the i2c-core.c directly if ACPI is
> > selected?
>
> I would rather see it merged there.
+1
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-20 9:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-18 12:17 i2c-core.ko renamed to i2ccore.ko Jean Delvare
[not found] ` <1411042678.7338.20.camel-H7Kp9ZFCxt/N0uC3ymp8PA@public.gmane.org>
2014-09-18 12:58 ` Mika Westerberg
[not found] ` <20140918125825.GR10854-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2014-09-18 15:10 ` Wolfram Sang
2014-09-19 8:28 ` Lan Tianyu
[not found] ` <541BE912.6060905-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-19 8:53 ` Mika Westerberg
[not found] ` <20140919085328.GC10854-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2014-09-20 9:02 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).