From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Mika Westerberg
<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: Carl Peng <carlpeng008-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Huang Rui <ray.huang-5C7GfCeVMHo@public.gmane.org>,
Christian Ruppert
<christian.ruppert-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] i2c: designware: Add support for AMD I2C controller
Date: Tue, 30 Sep 2014 07:57:50 +0200 [thread overview]
Message-ID: <20140930055750.GA1325@katana> (raw)
In-Reply-To: <20140930051956.GL1786-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
> > 1) They do not apply cleanly on top of other i2c-designware changes I
> > applied (check i2c/for-next I just pushed out). The conflicts might not
> > be hard, but they were not trivial enough for me to do them inbetween
> > other things. I'd be very happy about a repost on top of i2c/for-next.
>
> OK, I'll do that.
Great, much appreciated!
> > 2) "pretty much have" is not so convincing to me. That is such a generic
> > core, it probably has enough out-of-tree users as well.
>
> I wasn't aware that we care about out-of-tree users.
This is one example coming from a feeling that we should at least try to
make this change having less impact.
> > And with all these ACPI regressions from this cycle, I am very
> > cautious right now. Brainstorming: What about "depends on (ACPI &&
> > COMMON_CLK) || !ACPI"?
>
> Understood. I'll try the above.
Cool, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-30 5:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 9:26 [PATCH 1/2] i2c: designware: Rework probe() to get clock a bit later Mika Westerberg
[not found] ` <1411032367-20274-1-git-send-email-mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-09-18 9:26 ` [PATCH 2/2] i2c: designware: Add support for AMD I2C controller Mika Westerberg
[not found] ` <1411032367-20274-2-git-send-email-mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-09-20 9:36 ` Wolfram Sang
2014-09-22 9:12 ` Mika Westerberg
[not found] ` <20140922091207.GJ1786-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2014-09-22 12:29 ` Christian Ruppert
2014-09-22 13:48 ` Vineet Gupta
[not found] ` <C2D7FE5348E1B147BCA15975FBA230753C5DA425-uUKrqVzojAgF5QVroWrzJvufCSb+aD3WLzEdoUbNIic@public.gmane.org>
2014-09-22 14:00 ` Mika Westerberg
2014-09-22 14:16 ` Vineet Gupta
[not found] ` <C2D7FE5348E1B147BCA15975FBA230753C5DA47D-uUKrqVzojAgF5QVroWrzJvufCSb+aD3WLzEdoUbNIic@public.gmane.org>
2014-09-22 14:23 ` Mika Westerberg
2014-09-22 17:22 ` Christian Ruppert
[not found] ` <20140922172251.GA30685-7oYq3qWSd+k@public.gmane.org>
2014-09-23 10:05 ` Mika Westerberg
[not found] ` <20140923100559.GJ1786-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2014-09-29 10:24 ` Viresh Kumar
2014-09-26 3:50 ` Vineet Gupta
[not found] ` <5424E27C.2090302-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2014-10-07 9:30 ` Christian Ruppert
2014-10-07 12:35 ` arc platform code updates (was Re: [PATCH 2/2] i2c: designware: Add support for AMD I2C controller) Vineet Gupta
[not found] ` <C2D7FE5348E1B147BCA15975FBA230753C5E4C98-uUKrqVzojAgF5QVroWrzJvufCSb+aD3WLzEdoUbNIic@public.gmane.org>
2014-10-10 9:13 ` Christian Ruppert
[not found] ` <20141010091356.GA16492-7oYq3qWSd+k@public.gmane.org>
2014-10-10 16:31 ` Guenter Roeck
2014-09-29 21:24 ` [PATCH 2/2] i2c: designware: Add support for AMD I2C controller Wolfram Sang
2014-09-30 5:19 ` Mika Westerberg
[not found] ` <20140930051956.GL1786-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2014-09-30 5:57 ` Wolfram Sang [this message]
2014-09-19 7:08 ` [PATCH 1/2] i2c: designware: Rework probe() to get clock a bit later carl peng
[not found] ` <CAC5e1FqNpfnW=nAvn0LTuYm2Cwd332UCgzYkx-h1Y8WaRPdTTw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-19 8:54 ` Mika Westerberg
2014-09-20 9:35 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930055750.GA1325@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=carlpeng008-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=christian.ruppert-ux6zf3SgZrrQT0dZR+AlfA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=ray.huang-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).