From: Mika Westerberg <mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Lan Tianyu <tianyu.lan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2] i2c: move acpi code back into the core
Date: Tue, 30 Sep 2014 19:03:52 +0300 [thread overview]
Message-ID: <20140930160352.GV1786@lahna.fi.intel.com> (raw)
In-Reply-To: <20140930125520.61b57882-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
On Tue, Sep 30, 2014 at 12:55:20PM +0200, Jean Delvare wrote:
> The only thing which I find curious is that ACPI_I2C_OPREGION depends
> on I2C=y. Is this limitation a leftover from when the code was split to
> a separate file? It builds just fine with I2C=m, and I can't see why it
> wouldn't work. I have a patch to enable that, I can send it if it is
> the right thing to do. But maybe I'm missing something?
I think reason for the limitation is that if there happens to be some
AML code that is currently using the I2C operation region and the user
decides to unload the i2c-core.ko module or along those lines.
next prev parent reply other threads:[~2014-09-30 16:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 21:36 [PATCH v2] i2c: move acpi code back into the core Wolfram Sang
2014-09-25 7:26 ` Lan Tianyu
2014-09-25 9:02 ` Mika Westerberg
[not found] ` <1411594591-5048-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-09-30 10:55 ` Jean Delvare
[not found] ` <20140930125520.61b57882-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2014-09-30 16:03 ` Mika Westerberg [this message]
2014-09-30 18:46 ` Jean Delvare
2014-09-30 20:34 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930160352.GV1786@lahna.fi.intel.com \
--to=mika.westerberg-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=jdelvare-l3A5Bk7waGM@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tianyu.lan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).