From: Guenter Roeck <groeck@juniper.net>
To: Danielle Costantino <danielle.costantino@gmail.com>
Cc: linux-i2c <linux-i2c@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Jiri Kosina <jkosina@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Rajat Jain <rajatjain@juniper.net>
Subject: Re: Fwd: [Proposal] PM sleep children of inactive I2C bus segments off Masters in multi-master systems
Date: Wed, 1 Oct 2014 12:41:15 -0700 [thread overview]
Message-ID: <20141001194115.GA6948@svl-evodev-groeck.juniper.net> (raw)
In-Reply-To: <CAAVjN7edpkXYMHBm+wLegA_pc0hnm_YZf_z=Ni3h=EbDTmfegQ@mail.gmail.com>
On Wed, Oct 01, 2014 at 11:44:59AM -0700, Danielle Costantino wrote:
> Re-sending Proposal:
>
> Currently I2C mux devices that support multiple master arbitration are
> the i2c-mux-pca9541 and i2c-arb-gpio-challenge drivers. I propose to
> add the ability to configure an interrupt pin from the Master Selector
> device to indicate that bus ownership has been lost. Once the device
> loses ownership, all of its children should enter a pm sleep mode (as
> you can't talk to them at this point) until master-ship has been
> reacquired.
>
Not sure I understand what you are proposing here.
A typical use case would be a power supply such as the one supported by
drivers/hwmon/lineage-pem.c from both an active and standby system
controller. The power supply needs to be accessible from both controllers.
If one controller looses access, it can only mean that it did not follow
the access protocol. Similar, one controller enforcing access means that
it either does not follow the access protocol either, or that the other
end did not follow the protocol (or maybe the other end died).
In all cases, loss of access does not mean that the end device can or should
be put in sleep mode, not even logically. All it means is that there was
an access protocol error. Not sure if there is anything that can be done
about that, but putting the device into sleep mode does not seem to be
an appropriate response to me.
> This has come up as an issue when the master loses control over a bus
> the return code of all transactions to its lave devices is EIO (not
> very helpful).
>
But, again, doesn't that mean that there was some access protocol error ?
Shouldn't it try to re-acquire mastership instead, and block all accesses
to slaves until it acquired it ?
Thanks,
Guenter
next prev parent reply other threads:[~2014-10-01 19:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 18:34 [Proposal] PM sleep children of inactive I2C bus segments off Masters in multi-master systems Danielle Costantino
[not found] ` <CAAVjN7dwS62EKMnuZc_P1UjkbRVk6RXqJ91GwWZ96bbY5Ct-rg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-10-01 18:39 ` Fwd: " Danielle Costantino
2014-10-01 18:43 ` Guenter Roeck
2014-10-01 18:44 ` Danielle Costantino
2014-10-01 19:41 ` Guenter Roeck [this message]
2014-10-01 20:03 ` Danielle Costantino
2014-10-01 20:20 ` Guenter Roeck
2014-10-01 20:32 ` Danielle Costantino
2014-10-01 20:43 ` Guenter Roeck
2014-10-01 20:49 ` Danielle Costantino
[not found] ` <20141001204302.GA7744-VN48AwQc75yrkUfnaQMJWRyWsx42SBjsMbKr+jor3Jc@public.gmane.org>
2014-10-01 21:10 ` Wolfram Sang
2014-10-01 21:16 ` Guenter Roeck
2014-10-01 21:21 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001194115.GA6948@svl-evodev-groeck.juniper.net \
--to=groeck@juniper.net \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=danielle.costantino@gmail.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jkosina@suse.cz \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rajatjain@juniper.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).