* [PATCH] i2c: rk3x: fix 0 length write transfers
@ 2014-10-01 17:40 Alexandru M Stan
[not found] ` <1412185241-24950-1-git-send-email-amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Alexandru M Stan @ 2014-10-01 17:40 UTC (permalink / raw)
To: Max Schwarz, Wolfram Sang
Cc: Doug Anderson, Sonny Rao, addy ke, Jeffy Chen, ZhengShunQian,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Alexandru M Stan,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
i2cdetect -q was broken (everything was a false positive, and no transfers were
actually being sent over i2c). The way it works is by sending a 0 length write
request and checking for NACK. This patch fixes the 0 length writes and actually
sends them.
Reported-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Signed-off-by: Alexandru M Stan <amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
---
drivers/i2c/busses/i2c-rk3x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
index b41d979..f486d0e 100644
--- a/drivers/i2c/busses/i2c-rk3x.c
+++ b/drivers/i2c/busses/i2c-rk3x.c
@@ -238,7 +238,7 @@ static void rk3x_i2c_fill_transmit_buf(struct rk3x_i2c *i2c)
for (i = 0; i < 8; ++i) {
val = 0;
for (j = 0; j < 4; ++j) {
- if (i2c->processed == i2c->msg->len)
+ if ((i2c->processed == i2c->msg->len) && (cnt != 0))
break;
if (i2c->processed == 0 && cnt == 0)
--
2.1.0.rc2.206.gedb03e5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: rk3x: fix 0 length write transfers
[not found] ` <1412185241-24950-1-git-send-email-amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
@ 2014-10-01 22:47 ` Doug Anderson
2014-10-02 13:30 ` Max Schwarz
2014-10-03 0:27 ` Wolfram Sang
2 siblings, 0 replies; 5+ messages in thread
From: Doug Anderson @ 2014-10-01 22:47 UTC (permalink / raw)
To: Alexandru M Stan
Cc: Max Schwarz, Wolfram Sang, Sonny Rao, addy ke, Jeffy Chen,
ZhengShunQian, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
Heiko Stübner,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Alex,
On Wed, Oct 1, 2014 at 10:40 AM, Alexandru M Stan <amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote:
> i2cdetect -q was broken (everything was a false positive, and no transfers were
> actually being sent over i2c). The way it works is by sending a 0 length write
> request and checking for NACK. This patch fixes the 0 length writes and actually
> sends them.
>
> Reported-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Signed-off-by: Alexandru M Stan <amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-rk3x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> index b41d979..f486d0e 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -238,7 +238,7 @@ static void rk3x_i2c_fill_transmit_buf(struct rk3x_i2c *i2c)
> for (i = 0; i < 8; ++i) {
> val = 0;
> for (j = 0; j < 4; ++j) {
> - if (i2c->processed == i2c->msg->len)
> + if ((i2c->processed == i2c->msg->len) && (cnt != 0))
This looks good to me. Basically we still need to write the address
of the device onto the bus even if there's no data.
Reviewed-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Tested-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
-Doug
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: rk3x: fix 0 length write transfers
[not found] ` <1412185241-24950-1-git-send-email-amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-10-01 22:47 ` Doug Anderson
@ 2014-10-02 13:30 ` Max Schwarz
2014-10-03 0:27 ` Wolfram Sang
2014-10-03 0:27 ` Wolfram Sang
2 siblings, 1 reply; 5+ messages in thread
From: Max Schwarz @ 2014-10-02 13:30 UTC (permalink / raw)
To: Alexandru M Stan
Cc: Wolfram Sang, Doug Anderson, Sonny Rao, addy ke, Jeffy Chen,
ZhengShunQian, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Hi Alexandru,
On Wednesday 01 October 2014 at 10:40:41, Alexandru M Stan wrote:
> i2cdetect -q was broken (everything was a false positive, and no transfers
> were actually being sent over i2c). The way it works is by sending a 0
> length write request and checking for NACK. This patch fixes the 0 length
> writes and actually sends them.
>
> Reported-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Signed-off-by: Alexandru M Stan <amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-rk3x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> index b41d979..f486d0e 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -238,7 +238,7 @@ static void rk3x_i2c_fill_transmit_buf(struct rk3x_i2c
> *i2c) for (i = 0; i < 8; ++i) {
> val = 0;
> for (j = 0; j < 4; ++j) {
> - if (i2c->processed == i2c->msg->len)
> + if ((i2c->processed == i2c->msg->len) && (cnt != 0))
> break;
>
> if (i2c->processed == 0 && cnt == 0)
Yes, looks correct and makes i2cdetect work for me on Radxa Rock.
Reviewed-By: Max Schwarz <max.schwarz-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
Tested-By: Max Schwarz <max.schwarz-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
Cheers,
Max
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: rk3x: fix 0 length write transfers
2014-10-02 13:30 ` Max Schwarz
@ 2014-10-03 0:27 ` Wolfram Sang
0 siblings, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2014-10-03 0:27 UTC (permalink / raw)
To: Max Schwarz
Cc: Alexandru M Stan, Doug Anderson, Sonny Rao, addy ke, Jeffy Chen,
ZhengShunQian, linux-rockchip, heiko, linux-arm-kernel, linux-i2c,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
> Reviewed-By: Max Schwarz <max.schwarz@online.de>
> Tested-By: Max Schwarz <max.schwarz@online.de>
Checkpatch says:
WARNING: 'Tested-by:' is the preferred signature form
Same 'Reviewed-by:'
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: rk3x: fix 0 length write transfers
[not found] ` <1412185241-24950-1-git-send-email-amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-10-01 22:47 ` Doug Anderson
2014-10-02 13:30 ` Max Schwarz
@ 2014-10-03 0:27 ` Wolfram Sang
2 siblings, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2014-10-03 0:27 UTC (permalink / raw)
To: Alexandru M Stan
Cc: Max Schwarz, Doug Anderson, Sonny Rao, addy ke, Jeffy Chen,
ZhengShunQian, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
heiko-4mtYJXux2i+zQB+pC5nmwQ,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 537 bytes --]
On Wed, Oct 01, 2014 at 10:40:41AM -0700, Alexandru M Stan wrote:
> i2cdetect -q was broken (everything was a false positive, and no transfers were
> actually being sent over i2c). The way it works is by sending a 0 length write
> request and checking for NACK. This patch fixes the 0 length writes and actually
> sends them.
>
> Reported-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Signed-off-by: Alexandru M Stan <amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Applied to for-current, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-10-03 0:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-01 17:40 [PATCH] i2c: rk3x: fix 0 length write transfers Alexandru M Stan
[not found] ` <1412185241-24950-1-git-send-email-amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2014-10-01 22:47 ` Doug Anderson
2014-10-02 13:30 ` Max Schwarz
2014-10-03 0:27 ` Wolfram Sang
2014-10-03 0:27 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).