* [PATCH] i2c: at91: don't account as iowait
@ 2014-11-03 20:16 Wolfram Sang
[not found] ` <1415045776-6373-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2014-11-03 20:16 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA
Cc: Simon Lindgren, Ludovic Desroches, Wolfram Sang
iowait is for blkio [1]. I2C shouldn't use it.
[1] https://lkml.org/lkml/2014/11/3/317
Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
---
drivers/i2c/busses/i2c-at91.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
index 917d54588d95..e05a672db3e5 100644
--- a/drivers/i2c/busses/i2c-at91.c
+++ b/drivers/i2c/busses/i2c-at91.c
@@ -434,7 +434,7 @@ static int at91_do_twi_transfer(struct at91_twi_dev *dev)
}
}
- ret = wait_for_completion_io_timeout(&dev->cmd_complete,
+ ret = wait_for_completion_timeout(&dev->cmd_complete,
dev->adapter.timeout);
if (ret == 0) {
dev_err(dev->dev, "controller timed out\n");
--
2.1.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: at91: don't account as iowait
[not found] ` <1415045776-6373-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
@ 2014-11-05 10:55 ` Ludovic Desroches
2014-11-07 17:57 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Desroches @ 2014-11-05 10:55 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Simon Lindgren,
Ludovic Desroches
On Mon, Nov 03, 2014 at 09:16:16PM +0100, Wolfram Sang wrote:
> iowait is for blkio [1]. I2C shouldn't use it.
>
> [1] https://lkml.org/lkml/2014/11/3/317
>
> Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Acked-by: Ludovic Desroches <ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Thanks
> ---
> drivers/i2c/busses/i2c-at91.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> index 917d54588d95..e05a672db3e5 100644
> --- a/drivers/i2c/busses/i2c-at91.c
> +++ b/drivers/i2c/busses/i2c-at91.c
> @@ -434,7 +434,7 @@ static int at91_do_twi_transfer(struct at91_twi_dev *dev)
> }
> }
>
> - ret = wait_for_completion_io_timeout(&dev->cmd_complete,
> + ret = wait_for_completion_timeout(&dev->cmd_complete,
> dev->adapter.timeout);
> if (ret == 0) {
> dev_err(dev->dev, "controller timed out\n");
> --
> 2.1.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: at91: don't account as iowait
[not found] ` <1415045776-6373-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-11-05 10:55 ` Ludovic Desroches
@ 2014-11-07 17:57 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2014-11-07 17:57 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA; +Cc: Simon Lindgren, Ludovic Desroches
[-- Attachment #1: Type: text/plain, Size: 292 bytes --]
On Mon, Nov 03, 2014 at 09:16:16PM +0100, Wolfram Sang wrote:
> iowait is for blkio [1]. I2C shouldn't use it.
>
> [1] https://lkml.org/lkml/2014/11/3/317
>
> Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Added stable, applied to for-current, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-07 17:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-03 20:16 [PATCH] i2c: at91: don't account as iowait Wolfram Sang
[not found] ` <1415045776-6373-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-11-05 10:55 ` Ludovic Desroches
2014-11-07 17:57 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).