From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: [PATCH 2/4 v2] i2c-i801: Fallback to polling if request_irq() fails Date: Wed, 12 Nov 2014 10:24:07 +0100 Message-ID: <20141112102407.613f3664@endymion.delvare> References: <20141112101931.5f8c196a@endymion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141112101931.5f8c196a-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linux I2C Cc: Wolfram Sang List-Id: linux-i2c@vger.kernel.org The i2c-i801 driver can work without interrupts, so there is no reason to make a request_irq failure fatal. Instead we can simply fallback to polling. Signed-off-by: Jean Delvare Cc: Wolfram Sang --- Changes since v1: * Always log whether the driver is using polling or PCI interrupt. drivers/i2c/busses/i2c-i801.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- linux-3.18-rc4.orig/drivers/i2c/busses/i2c-i801.c 2014-11-10 22:29:42.788955868 +0100 +++ linux-3.18-rc4/drivers/i2c/busses/i2c-i801.c 2014-11-11 14:56:35.777941563 +0100 @@ -1242,10 +1242,11 @@ static int i801_probe(struct pci_dev *de if (err) { dev_err(&dev->dev, "Failed to allocate irq %d: %d\n", dev->irq, err); - goto exit_release; + priv->features &= ~FEATURE_IRQ; } - dev_info(&dev->dev, "SMBus using PCI Interrupt\n"); } + dev_info(&dev->dev, "SMBus using %s\n", + priv->features & FEATURE_IRQ ? "PCI interrupt" : "polling"); /* set up the sysfs linkage to our parent device */ priv->adapter.dev.parent = &dev->dev; @@ -1272,7 +1273,6 @@ static int i801_probe(struct pci_dev *de exit_free_irq: if (priv->features & FEATURE_IRQ) free_irq(dev->irq, priv); -exit_release: pci_release_region(dev, SMBBAR); exit: kfree(priv); -- Jean Delvare SUSE L3 Support