* [PATCH] i2c: imx: simplify i2c_imx_dma_write() a little
@ 2014-11-19 9:11 Wolfram Sang
[not found] ` <1416388299-4650-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2014-11-19 9:11 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA; +Cc: Yuan Yao, Wolfram Sang
Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
---
drivers/i2c/busses/i2c-imx.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index d0668d0d626d..aab1f4bb9e30 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -657,11 +657,7 @@ static int i2c_imx_dma_write(struct imx_i2c_struct *i2c_imx,
if (result)
return result;
- result = i2c_imx_acked(i2c_imx);
- if (result)
- return result;
-
- return 0;
+ return i2c_imx_acked(i2c_imx);
}
static int i2c_imx_dma_read(struct imx_i2c_struct *i2c_imx,
--
2.1.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] i2c: imx: simplify i2c_imx_dma_write() a little
[not found] ` <1416388299-4650-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
@ 2014-11-19 10:15 ` Yao Yuan
[not found] ` <BL2PR03MB338C5B78DA771E61570E6CD83890-AZ66ij2kwaZYLYlmg7qx2OO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Yao Yuan @ 2014-11-19 10:15 UTC (permalink / raw)
To: Wolfram Sang, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Great, It's quite simpler than before.
I should take more attention on make the code cleanly and efficiently.
Best Regards,
Yuan Yao
> -----Original Message-----
> From: Wolfram Sang [mailto:wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org]
> Sent: Wednesday, November 19, 2014 5:12 PM
> To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: Yuan Yao-B46683; Wolfram Sang
> Subject: [PATCH] i2c: imx: simplify i2c_imx_dma_write() a little
>
> Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-imx.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index d0668d0d626d..aab1f4bb9e30 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -657,11 +657,7 @@ static int i2c_imx_dma_write(struct imx_i2c_struct
> *i2c_imx,
> if (result)
> return result;
>
> - result = i2c_imx_acked(i2c_imx);
> - if (result)
> - return result;
> -
> - return 0;
> + return i2c_imx_acked(i2c_imx);
> }
>
> static int i2c_imx_dma_read(struct imx_i2c_struct *i2c_imx,
> --
> 2.1.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: imx: simplify i2c_imx_dma_write() a little
[not found] ` <BL2PR03MB338C5B78DA771E61570E6CD83890-AZ66ij2kwaZYLYlmg7qx2OO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
@ 2014-11-19 12:04 ` Wolfram Sang
0 siblings, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2014-11-19 12:04 UTC (permalink / raw)
To: Yao Yuan; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
On Wed, Nov 19, 2014 at 10:15:34AM +0000, Yao Yuan wrote:
> Great, It's quite simpler than before.
> I should take more attention on make the code cleanly and efficiently.
Don't worry, nobody is perfect!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-19 12:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-19 9:11 [PATCH] i2c: imx: simplify i2c_imx_dma_write() a little Wolfram Sang
[not found] ` <1416388299-4650-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-11-19 10:15 ` Yao Yuan
[not found] ` <BL2PR03MB338C5B78DA771E61570E6CD83890-AZ66ij2kwaZYLYlmg7qx2OO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2014-11-19 12:04 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).