From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] i2c: rk3x: add Kconfig dependency on COMMON_CLK Date: Mon, 24 Nov 2014 09:05:09 +0100 Message-ID: <20141124080509.GK4431@pengutronix.de> References: <1499103.qTrcqP28lh@typ> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1499103.qTrcqP28lh@typ> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Max Schwarz Cc: Wolfram Sang , Doug Anderson , Linux I2C , Jean Delvare , Heiko =?iso-8859-1?Q?St=FCbner?= List-Id: linux-i2c@vger.kernel.org Hello Max, On Mon, Nov 24, 2014 at 01:32:27AM +0100, Max Schwarz wrote: > Now that we are using the clk notifier framework we get compile error= s > without COMMON_CLK. But the driver fails to probe without COMMON_CLK > anyways, so just add that as a Kconfig dependency. Hmm, I wonder how a kernel that fails to compile can even start probing =2E.. :-) Anyhow, it would be nice to quote the compiler error you fix here and point out the patch that failed to add the needed dependency. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= |