From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: "Uwe Kleine-König"
<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: "Max Schwarz"
<max.schwarz-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>,
"Doug Anderson"
<dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
"Linux I2C" <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Jean Delvare" <jdelvare-l3A5Bk7waGM@public.gmane.org>,
"Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Subject: Re: [PATCH] i2c: rk3x: add Kconfig dependency on COMMON_CLK
Date: Mon, 24 Nov 2014 10:31:16 +0100 [thread overview]
Message-ID: <20141124093116.GB3733@katana> (raw)
In-Reply-To: <20141124080509.GK4431-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 732 bytes --]
On Mon, Nov 24, 2014 at 09:05:09AM +0100, Uwe Kleine-König wrote:
> Hello Max,
>
> On Mon, Nov 24, 2014 at 01:32:27AM +0100, Max Schwarz wrote:
> > Now that we are using the clk notifier framework we get compile errors
> > without COMMON_CLK. But the driver fails to probe without COMMON_CLK
> > anyways, so just add that as a Kconfig dependency.
> Hmm, I wonder how a kernel that fails to compile can even start probing
> ... :-)
>
> Anyhow, it would be nice to quote the compiler error you fix here and
> point out the patch that failed to add the needed dependency.
Yes, that would be perfect. But for fixing the breakage in linux-next we
created, this is good enough for me.
Applied to for-next, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-24 9:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 0:32 [PATCH] i2c: rk3x: add Kconfig dependency on COMMON_CLK Max Schwarz
2014-11-24 8:05 ` Uwe Kleine-König
[not found] ` <20141124080509.GK4431-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-11-24 9:31 ` Wolfram Sang [this message]
2014-11-24 9:38 ` Uwe Kleine-König
[not found] ` <20141124093823.GN4431-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-11-24 9:58 ` Wolfram Sang
2014-11-24 9:59 ` Uwe Kleine-König
[not found] ` <20141124095954.GR4431-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-11-24 10:06 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141124093116.GB3733@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=jdelvare-l3A5Bk7waGM@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=max.schwarz-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org \
--cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).