[PATCH v2] i2c: rk3x: add Kconfig dependency on COMMON_CLK

[PATCH v2] i2c: rk3x: add Kconfig dependency on COMMON_CLK

[Max Schwarz]

Fixes: 5a6f1566f6a0 ("i2c: rk3x: handle dynamic clock rate changes correctly")

which introduced a dependency on clock rate notifiers. Now we get compiler
errors if compiled without COMMON_CLK:

drivers/i2c/busses/i2c-rk3x.c: In function 'rk3x_i2c_clk_notifier_cb':
drivers/i2c/busses/i2c-rk3x.c:634:7: error: 'PRE_RATE_CHANGE' undeclared (first use in this function)
[...]

But the driver has always depended on COMMON_CLK even if it compiled
 - in fact it fails to probe without it. So add that as a Kconfig
dependency.

Signed-off-by: Max Schwarz <max.schwarz-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
---

Wolfram,

here is a version with better commit msg in case you still want to take that
instead of my quick fix.

Uwe, thanks for your comments!

Cheers,
  Max

 drivers/i2c/busses/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index a940e33..bb66119 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -720,7 +720,7 @@ config I2C_RIIC
 
 config I2C_RK3X
 	tristate "Rockchip RK3xxx I2C adapter"
-	depends on OF
+	depends on OF && COMMON_CLK
 	help
 	  Say Y here to include support for the I2C adapter in Rockchip RK3xxx
 	  SoCs.
-- 
1.9.1

Re: [PATCH v2] i2c: rk3x: add Kconfig dependency on COMMON_CLK

[Uwe Kleine-König]

On Mon, Nov 24, 2014 at 10:46:25AM +0100, Max Schwarz wrote:
> Fixes: 5a6f1566f6a0 ("i2c: rk3x: handle dynamic clock rate changes correctly")
This line usually goes into the S-o-B block below. So maybe:

Commit 5a6f1566f6a0 ("i2c: rk3x: handle dynamic clock rate changes
correctly") introduced a dependency ...

and then the Fixes line above your S-o-b.

> 
> which introduced a dependency on clock rate notifiers. Now we get compiler
> errors if compiled without COMMON_CLK:
> 
> drivers/i2c/busses/i2c-rk3x.c: In function 'rk3x_i2c_clk_notifier_cb':
> drivers/i2c/busses/i2c-rk3x.c:634:7: error: 'PRE_RATE_CHANGE' undeclared (first use in this function)
> [...]
> 
> But the driver has always depended on COMMON_CLK even if it compiled
>  - in fact it fails to probe without it. So add that as a Kconfig
> dependency.
> 
> Signed-off-by: Max Schwarz <max.schwarz-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
> ---
> 
> Wolfram,
> 
> here is a version with better commit msg in case you still want to take that
> instead of my quick fix.
Thanks for your quick turn around.

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |