From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v3] i2c: rk3x: add Kconfig dependency on COMMON_CLK Date: Mon, 24 Nov 2014 10:57:24 +0100 Message-ID: <20141124095724.GQ4431@pengutronix.de> References: <1565974.mtHL9sZWPl@typ> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1565974.mtHL9sZWPl@typ> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Max Schwarz Cc: Wolfram Sang , Doug Anderson , Linux I2C , Jean Delvare , Heiko =?iso-8859-1?Q?St=FCbner?= List-Id: linux-i2c@vger.kernel.org Hallo, On Mon, Nov 24, 2014 at 10:55:45AM +0100, Max Schwarz wrote: > Commit 5a6f1566f6a0 ("i2c: rk3x: handle dynamic clock rate changes > correctly") introduced a dependency on clock rate notifiers. Now we g= et > compiler errors if compiled without COMMON_CLK: >=20 > drivers/i2c/busses/i2c-rk3x.c: In function 'rk3x_i2c_clk_notifier_cb'= : > drivers/i2c/busses/i2c-rk3x.c:634:7: error: 'PRE_RATE_CHANGE' undecla= red (first use in this function) > [...] >=20 > But the driver has always depended on COMMON_CLK even if it compiled > - in fact it fails to probe without it. So add that as a Kconfig > dependency. >=20 > Fixes: 5a6f1566f6a0 ("i2c: rk3x: handle dynamic clock rate changes co= rrectly") > Signed-off-by: Max Schwarz > --- >=20 > Wolfram, >=20 > here is a version with *even* better commit msg in case you still wan= t to > take that instead of my quick fix. Acked-by: Uwe Kleine-K=F6nig Thanks Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= |