[PATCH] i2c: rk3x: add Kconfig dependency on COMMON_CLK

[PATCH] i2c: rk3x: add Kconfig dependency on COMMON_CLK

[Max Schwarz]

Now that we are using the clk notifier framework we get compile errors
without COMMON_CLK. But the driver fails to probe without COMMON_CLK
anyways, so just add that as a Kconfig dependency.

Signed-off-by: Max Schwarz <max.schwarz-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org>
---

As reported by the kbuild test robot at Intel Open Source.

 drivers/i2c/busses/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index a940e33..bb66119 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -720,7 +720,7 @@ config I2C_RIIC
 
 config I2C_RK3X
 	tristate "Rockchip RK3xxx I2C adapter"
-	depends on OF
+	depends on OF && COMMON_CLK
 	help
 	  Say Y here to include support for the I2C adapter in Rockchip RK3xxx
 	  SoCs.
-- 
1.9.1

Re: [PATCH] i2c: rk3x: add Kconfig dependency on COMMON_CLK

[Uwe Kleine-König]

Hello Max,

On Mon, Nov 24, 2014 at 01:32:27AM +0100, Max Schwarz wrote:
> Now that we are using the clk notifier framework we get compile errors
> without COMMON_CLK. But the driver fails to probe without COMMON_CLK
> anyways, so just add that as a Kconfig dependency.
Hmm, I wonder how a kernel that fails to compile can even start probing
... :-)

Anyhow, it would be nice to quote the compiler error you fix here and
point out the patch that failed to add the needed dependency.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: [PATCH] i2c: rk3x: add Kconfig dependency on COMMON_CLK

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

On Mon, Nov 24, 2014 at 09:05:09AM +0100, Uwe Kleine-König wrote:
> Hello Max,
> 
> On Mon, Nov 24, 2014 at 01:32:27AM +0100, Max Schwarz wrote:
> > Now that we are using the clk notifier framework we get compile errors
> > without COMMON_CLK. But the driver fails to probe without COMMON_CLK
> > anyways, so just add that as a Kconfig dependency.
> Hmm, I wonder how a kernel that fails to compile can even start probing
> ... :-)
> 
> Anyhow, it would be nice to quote the compiler error you fix here and
> point out the patch that failed to add the needed dependency.

Yes, that would be perfect. But for fixing the breakage in linux-next we
created, this is good enough for me.

Applied to for-next, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] i2c: rk3x: add Kconfig dependency on COMMON_CLK

[Uwe Kleine-König]

Hey Wolfram,

On Mon, Nov 24, 2014 at 10:31:16AM +0100, Wolfram Sang wrote:
> On Mon, Nov 24, 2014 at 09:05:09AM +0100, Uwe Kleine-König wrote:
> > Hello Max,
> > 
> > On Mon, Nov 24, 2014 at 01:32:27AM +0100, Max Schwarz wrote:
> > > Now that we are using the clk notifier framework we get compile errors
> > > without COMMON_CLK. But the driver fails to probe without COMMON_CLK
> > > anyways, so just add that as a Kconfig dependency.
> > Hmm, I wonder how a kernel that fails to compile can even start probing
> > ... :-)
> > 
> > Anyhow, it would be nice to quote the compiler error you fix here and
> > point out the patch that failed to add the needed dependency.
> 
> Yes, that would be perfect. But for fixing the breakage in linux-next we
> created, this is good enough for me.
> 
> Applied to for-next, thanks!
Just for me to learn: is your for-next stable once pushed?

As you didn't push out yet, it's

Fixes: 5a6f1566f6a0 ("i2c: rk3x: handle dynamic clock rate changes correctly")

party on,
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: [PATCH] i2c: rk3x: add Kconfig dependency on COMMON_CLK

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]


> > Applied to for-next, thanks!
> Just for me to learn: is your for-next stable once pushed?

Nope, I push manually when I feel comfortable. That might change,
though.

> As you didn't push out yet, it's
> 
> Fixes: 5a6f1566f6a0 ("i2c: rk3x: handle dynamic clock rate changes correctly")

Actually, it is 249051f49907. I rebased my internal i2c/for-3.19 tree to
fix an authorship and merged that into i2c/for-next. For those reasons,
my current policy is to use "Fixes:" only for commits which hit the
linus-tree. I probably shouldn't do such things, but as long as I was
working on my own, this worked pretty well ;)


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] i2c: rk3x: add Kconfig dependency on COMMON_CLK

[Uwe Kleine-König]

On Mon, Nov 24, 2014 at 10:58:00AM +0100, Wolfram Sang wrote:
> 
> > > Applied to for-next, thanks!
> > Just for me to learn: is your for-next stable once pushed?
> 
> Nope, I push manually when I feel comfortable. That might change,
> though.
> 
> > As you didn't push out yet, it's
> > 
> > Fixes: 5a6f1566f6a0 ("i2c: rk3x: handle dynamic clock rate changes correctly")
> 
> Actually, it is 249051f49907. I rebased my internal i2c/for-3.19 tree to
> fix an authorship and merged that into i2c/for-next. For those reasons,
> my current policy is to use "Fixes:" only for commits which hit the
> linus-tree. I probably shouldn't do such things, but as long as I was
> working on my own, this worked pretty well ;)
If it's not stable you can even squash in the fix. In this case the
commit log drill was superfluous for this commit, but (hopefully) still
useful for the future.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: [PATCH] i2c: rk3x: add Kconfig dependency on COMMON_CLK

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 114 bytes --]


> commit log drill was superfluous for this commit, but (hopefully) still
> useful for the future.

I think so.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]