From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] omap: i2c: don't check bus state IP rev3.3 and earlier Date: Mon, 24 Nov 2014 13:08:10 -0800 Message-ID: <20141124210809.GG2817@atomide.com> References: <1416685634-5864-3-git-send-email-al.kochet@gmail.com> <1416861189-17109-1-git-send-email-al.kochet@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1416861189-17109-1-git-send-email-al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexander Kochetkov Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Felipe Balbi , Wolfram Sang , Kevin Hilman List-Id: linux-i2c@vger.kernel.org * Alexander Kochetkov [141124 12:35]: > Commit 903c3859f77f9b0aace551da03267ef7a211dbc4 ("i2c: omap: implement > workaround for handling invalid BB-bit values") introduce the error result > in boot test fault on OMAP3530 boards > > The patch fix the error (disable i2c bus test for OMAP3530). Maybe add Reported-by: credit for Kevin Hilman here? Other than that, this fixes the problem for me: Tested-by: Tony Lindgren > Signed-off-by: Alexander Kochetkov > Fixes: 903c3859f77f9b0aace551da03267ef7a211dbc4 > --- > drivers/i2c/busses/i2c-omap.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c > index 5d92d0e..4563200 100644 > --- a/drivers/i2c/busses/i2c-omap.c > +++ b/drivers/i2c/busses/i2c-omap.c > @@ -344,8 +344,10 @@ static int omap_i2c_reset(struct omap_i2c_dev *dev) > /* SYSC register is cleared by the reset; rewrite it */ > omap_i2c_write_reg(dev, OMAP_I2C_SYSC_REG, sysc); > > - /* Schedule I2C-bus monitoring on the next transfer */ > - dev->bb_valid = 0; > + if (dev->rev > OMAP_I2C_REV_ON_3430_3530) { > + /* Schedule I2C-bus monitoring on the next transfer */ > + dev->bb_valid = 0; > + } > } > > return 0; > @@ -460,7 +462,7 @@ static int omap_i2c_init(struct omap_i2c_dev *dev) > dev->scllstate = scll; > dev->sclhstate = sclh; > > - if (dev->rev < OMAP_I2C_OMAP1_REV_2) { > + if (dev->rev <= OMAP_I2C_REV_ON_3430_3530) { > /* Not implemented */ > dev->bb_valid = 1; > } > -- > 1.7.9.5 >