From: Wolfram Sang <wsa@the-dreams.de>
To: Grant Likely <grant.likely@linaro.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2 11/14] i2c/of: Factor out Devicetree registration code
Date: Tue, 25 Nov 2014 15:11:14 +0100 [thread overview]
Message-ID: <20141125141114.GB1843@katana> (raw)
In-Reply-To: <1416868422-22103-12-git-send-email-grant.likely@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]
On Mon, Nov 24, 2014 at 10:33:39PM +0000, Grant Likely wrote:
> From: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
>
> Dynamically inserting i2c client device nodes requires the use
> of a single device registration method. Factor out the loop body of
> of_i2c_register_devices() so that it can be called for individual
> device_nodes instead of for all the children of a node.
>
> Note: The diff of this commit looks far more complicated than it
> actually is due the indentation being changed for a large block of code.
> When viewed using the diff -w flag to ignore whitespace changes it can
> be seen that the change is actually quite simple.
>
> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
> [grant.likely: Made new function static and removed changes to header]
> Signed-off-by: Grant Likely <grant.likely@linaro.org>
> Cc: Wolfram Sang <wsa@the-dreams.de>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: linux-i2c@vger.kernel.org
Reviewed-by: Wolfram Sang <wsa@the-dreams.de>
I'd prefer that this series goes through your tree. There is still this
merge conflict, but that is an easy one like I mentioned in my last
review.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-25 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1416868422-22103-1-git-send-email-grant.likely@linaro.org>
2014-11-24 22:33 ` [PATCH v2 11/14] i2c/of: Factor out Devicetree registration code Grant Likely
2014-11-25 14:11 ` Wolfram Sang [this message]
2014-11-24 22:33 ` [PATCH v2 12/14] i2c/of: Add OF_RECONFIG notifier handler Grant Likely
2014-11-25 14:11 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125141114.GB1843@katana \
--to=wsa@the-dreams.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).